Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use kubernetes-client/gen generators to generate python client #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Jul 6, 2017

ref: #243

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2017

echo "--- Generating client ..."
mvn -f "${SCRIPT_ROOT}/pom.xml" clean generate-sources -Dgenerator.spec.path="${SCRIPT_ROOT}/swagger.json" -Dgenerator.output.path="${CLIENT_ROOT}" -Dgenerator.package.name=client -D=generator.client.version=${CLIENT_VERSION}
echo ">>> Clonging gen repo"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloning :)

@dims
Copy link
Collaborator

dims commented Jul 6, 2017

Looks good, just one tiny typo. Haven't tried it though. We can let this merge and then fixup any issues. Will try to run it later this week

@mbohlool
Copy link
Contributor Author

mbohlool commented Jul 6, 2017

Thanks. I also removed unused files too (the ones that duplicates gen repo like preprocessing script). It is working, but I need to update third party resources in the gen repo. I am going to move the #283 to gen repo.

@dims
Copy link
Collaborator

dims commented Jul 6, 2017

LGTM 👍

@mbohlool mbohlool merged commit 820366c into kubernetes-client:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants