Add files in root directory to dist #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbohlool
reviewed
Oct 18, 2017
| exclude .gitignore | ||
| exclude .gitreview | ||
|
|
||
| global-exclude *.pyc |
There was a problem hiding this comment.
nit: add new line at the end of the file.
|
Thanks for the fix @dims. Just one nit otherwise LGTM. |
19fb5ad to
480723f
Compare
By adding a MANIFEST.in, we can list the files we need to include into the tgz when we run "python setup.py sdist". With this change you should see the following files in the tgz file. LICENSE MANIFEST.in OWNERS PKG-INFO README.md RELEASE.md requirements.txt setup.cfg setup.py test-requirements.txt tox.ini
|
@dims, I merged this but can you also add a line to the CHANGELOG for this? |
dims
added a commit
to dims/client-python
that referenced
this pull request
Oct 19, 2017
Add info about kubernetes-client#369
Merged
|
Done @mbohlool |
bh717
pushed a commit
to bh717/python-dapp
that referenced
this pull request
Apr 1, 2024
Add info about kubernetes-client/python#369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a MANIFEST.in, we can list the files we need to include
into the tgz when we run "python setup.py sdist". With this change
you should see the following files in the tgz file.
LICENSE
MANIFEST.in
OWNERS
PKG-INFO
README.md
RELEASE.md
requirements.txt
setup.cfg
setup.py
test-requirements.txt
tox.ini
Fixes #361