Update python-base submodule to pick up changes #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove required idp-certificate-authority-data in kubeconfig for oidc token refresh; Watch properly decodes resourceVersion from custom object response.
|
/cc @yliaog |
yliaog
reviewed
Jul 10, 2018
| # v7.0.0a1 | ||
| **NOTE:** | ||
| - We are doing an Alpha release for v7.0.0 because there will be an **ACTION REQUIRED** API breaking change in this client to support Python 3.7, which substitutes the currently being-used `async` reserved keyword [kubernetes-client/gen#67](https://github.com/kubernetes-client/gen/pull/67) | ||
|
|
There was a problem hiding this comment.
so the PR has not been merged, do you want to wait for it?
There was a problem hiding this comment.
I'd like to release v7 alpha first, and we can release v7 stable afterwards to introduce the breaking change. v7 alpha won't include that change. What do you think?
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
Tests are green after rebase on master. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove required idp-certificate-authority-data in kubeconfig for oidc token refresh;
Watch properly decodes resourceVersion from custom object response.
And also update CHANGELOG about the upcoming breaking change for substituting the currently being-used
asynckeyword, which is reserved in Python 3.7.