Add default kube config location #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.40% (diff: 42.85%)@@ master #64 diff @@
==========================================
Files 9 9
Lines 632 637 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 594 595 +1
- Misses 38 42 +4
Partials 0 0
|
mml
suggested changes
Dec 15, 2016
| def list_kube_config_contexts(config_file): | ||
| def list_kube_config_contexts(config_file=None): | ||
|
|
||
| if not config_file: |
There was a problem hiding this comment.
I would use if config_file is not None here.
There was a problem hiding this comment.
You mean if config_file is None right?
| @@ -259,6 +264,9 @@ def load_kube_config(config_file, context=None): | |||
| from config file will be used. | |||
| """ | |||
|
|
|||
| if not config_file: | |||
There was a problem hiding this comment.
I would use if config_file is not None here.
8d0607c to
fff29bf
Compare
yliaog
added a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
Watch properly decode resourceVersion from custom object response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubenetes.config.load_configneeds the location of config file to load it. We can set the location to the default location of ~/.kube/config.