-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Release 10.0.0 #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 21 commits into
kubernetes-client:release-10.0
from
roycaihw:release-10.0
Jul 2, 2019
Merged
Release 10.0.0 #864
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
06776ce
Rebase code and add namespaced method
johscheuer 15d36c9
Use optional parameter for method
johscheuer 80339ef
Add more documentation to new namespace parameter
johscheuer 914b6aa
Updating Submodule for GCP Email Scope Addition
axelsteingrimsson 7fb3a25
Merge pull request #809 from axelsteingrimsson/add_email_scope_to_gcp…
k8s-ci-robot a579f15
Fix broken dependencies.
Ark-kun 89de1fa
Correct inconsistent spacing and typos
5e512ff
Merge pull request #820 from scottilee/docs
k8s-ci-robot 05c1a43
Merge pull request #816 from Ark-kun/patch-1
k8s-ci-robot c86e489
Merge pull request #782 from johscheuer/create-from-yaml-namespaced
k8s-ci-robot d7300db
Don't use latest stable version for minikube
oz123 c4c18d9
Merge pull request #856 from oz123/test-suite-change-k8s-version
k8s-ci-robot 14f97fc
update python-base submodule
roycaihw 13394b0
add changelog for python-base update
roycaihw 8622ac4
generated client update for 10.0.0-snapshot
roycaihw 38e35af
add changelog for python repo changes; update readme
roycaihw c488354
Merge pull request #861 from roycaihw/release-10.0.0
k8s-ci-robot 6cc3331
Merge branch 'master' of github.com:kubernetes-client/python into rel…
roycaihw 47102be
update version constants for 10.0.0 release
roycaihw 9c8bd4a
re-generated client for 10.0.0 release
roycaihw 9e8b65c
add CHANGELOG for CR api change from kubernetes-client/gen repo
roycaihw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,3 @@ approvers: | |
- lavalamp | ||
- yliaog | ||
- roycaihw | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
# Release process | ||
|
||
Release process of python client involve creating (or updating) a release | ||
branch, update release tags, create distribution packages and upload them to | ||
pip. | ||
The release process of the python client involves creating (or updating) a release | ||
branch, updating release tags, and creating distribution packages and uploading them to | ||
pypi. | ||
|
||
## Change logs | ||
Make sure changes logs are up to date [here](https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md). | ||
If they are not, follow commits added after last release and update/commit | ||
Make sure the change logs are up to date [here](https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md). | ||
If they are not, follow commits added after the last release and update/commit | ||
the change logs to master. | ||
|
||
Then based on the release, follow one of next two steps. | ||
|
||
## Update pre-release branch | ||
|
||
Release branch name should have release-x.x format. All minor and pre-releases | ||
should be on the same branch. To update an existing branch with master(only for | ||
The release branch name should have release-x.x format. All minor and pre-releases | ||
should be on the same branch. To update an existing branch with master (only for | ||
latest pre-release): | ||
|
||
```bash | ||
|
@@ -37,8 +37,8 @@ cherry pick first: | |
scripts/cherry_pick_pull.sh | ||
``` | ||
|
||
Do not merge master into an stable releast branch. Run the script without | ||
parameters and follow its instruction to create cherry pick PR and get the | ||
Do not merge master into a stable release branch. Run the script without | ||
parameters and follow its instructions to create a cherry pick PR. Get the | ||
PR merged then update your local branch: | ||
|
||
```bash | ||
|
@@ -49,26 +49,27 @@ git rebase upstream/$RELEASE_BRANCH | |
``` | ||
|
||
## Sanity check generated client | ||
We need to make sure there is no API changes after running update client | ||
scripts. Such changes should be committed to master branch first. Run this | ||
|
||
We need to make sure there are no API changes after running update client | ||
scripts. Such changes should be committed to the master branch first. Run this | ||
command: | ||
|
||
```bash | ||
scripts/update-client.sh | ||
``` | ||
|
||
And make sure there is no API change (version number changes should be fine | ||
as they will be updated in next step anyway). Do not commit any changes at | ||
this step and go back to master branch if there is any API changes. | ||
as they will be updated in the next step anyway). Do not commit any changes at | ||
this step and go back to the master branch if there are any API changes. | ||
|
||
## Update release tags | ||
|
||
Release tags are in scripts/constants.py file. These are the constants you may | ||
Release tags are in the "scripts/constants.py" file. These are the constants you may | ||
need to update: | ||
|
||
CLIENT_VERSION: Client version should follow x.y.zDn where x,y,z are version | ||
numbers (integers) and D is one of "a" for alpha or "b" for beta and n is the | ||
pre-release number. For a final release, "Dn" part should be omitted. Examples: | ||
pre-release number. For a final release, the "Dn" part should be omitted. Examples: | ||
1.0.0a1, 2.0.1b2, 1.5.1. | ||
|
||
DEVELOPMENT_STATUS: Update it to one of the values of "Development Status" | ||
|
@@ -89,8 +90,9 @@ git push upstream $RELEASE_BRANCH | |
``` | ||
|
||
## Make distribution packages | ||
|
||
First make sure you are using a clean version of python. Use virtualenv and | ||
pyenv packages, make sure you are using python 2.7.12. I would normally do this | ||
pyenv packages. Make sure you are using python 2.7.12. I would normally do this | ||
on a clean machine: | ||
|
||
(install [pyenv](https://github.com/yyuu/pyenv#installation)) | ||
|
@@ -128,9 +130,9 @@ python setup.py bdist_wheel --universal | |
ls dist/ | ||
``` | ||
|
||
You should see two files in dist folder. kubernetes\*.whl and kubernetes\*.tar.gz. | ||
You should see two files in dist folder: "kubernetes\*.whl" and "kubernetes\*.tar.gz". | ||
|
||
TODO: We need a dry-run option an some way to test package upload process to pypi. | ||
TODO: We need a dry-run option and some way to test the package upload process to pypi. | ||
|
||
If everything looks good, run this command to upload packages to pypi: | ||
|
||
|
@@ -142,13 +144,13 @@ twine upload dist/* | |
|
||
Create a gihub release by starting from | ||
[this page](https://github.com/kubernetes-client/python/releases). | ||
Click Deaft new release button. Name the tag the same as CLIENT_VERSION. Change | ||
Click the `Draft a new release button`. Name the tag the same as CLIENT_VERSION. Change | ||
the target branch to "release-x.y". If the release is a pre-release, check the | ||
`This is a pre-release` option. | ||
|
||
|
||
## Announcement | ||
Send an announcement email to [email protected] with the subject [ANNOUNCE] kubernetes python-client $VERSION is released | ||
|
||
Send an announcement email to [email protected] with the subject: [ANNOUNCE] kubernetes python-client $VERSION is released | ||
|
||
## Cleanup | ||
|
||
|
@@ -159,5 +161,4 @@ rm -rf .release | |
|
||
TODO: Convert steps in this document to an (semi-) automated script. | ||
|
||
|
||
ref: https://packaging.python.org/distributing/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,29 @@ | ||
# Submodules | ||
|
||
To comply with [client library structure requirement](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/csi-client-structure-proposal.md), | ||
python client base utilities is moved into kubernetes-client/python-base repo. `git submodules` is being used to handle dependency to that repo. | ||
This document will provide basic steps to get submodules work. | ||
python client base utilities is moved into the [kubernetes-client/python-base](https://github.com/kubernetes-client/python-base) repo. `git submodules` is being used to handle dependency to that repo. | ||
This document will provide basic steps to get submodules working. | ||
|
||
# Clone repo | ||
To clone repo, you need to pass `recursive` parameter to make the clone also get submodules: | ||
|
||
To clone the repo, you need to pass the `recursive` parameter to make the clone also get submodules: | ||
|
||
```bash | ||
git clone --recursive https://github.com/kubernetes-client/python.git | ||
``` | ||
|
||
if you already clone repo with no `--recursive` option, you can run this command to get submodules: | ||
if you have already cloned the repo with no `--recursive` option, you can run this command to get submodules: | ||
|
||
```bash | ||
git submodule update --init | ||
``` | ||
|
||
# Update submodule | ||
If you changed kubernetes-client/python-base and want to pull your changes into this repo run this command: | ||
|
||
If you changed [kubernetes-client/python-base](https://github.com/kubernetes-client/python-base) and want to pull your changes into this repo run this command: | ||
|
||
```bash | ||
git submodule update --remote | ||
``` | ||
|
||
Once updated, you should create a new PR to commit changes to the repository. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule base
updated
3 files
+21 −7 | config/kube_config.py | |
+97 −4 | config/kube_config_test.py | |
+1 −1 | stream/ws_client.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this happening on the release branch, not on master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was merged yesterday kubernetes-client/gen#119 and gets included today since we pull the latest
kubernetes-client/gen
. It's a backwards-compatible fix IMO, so I keep it here. The master branch will sync up when we re-generate client there next time (11.0.0a1)alternatively I can pin
kubernetes-client/gen
to exclude this change for this release. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. fine to include it.