Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Temporary pin minikube to 1.2.0 due to regression in 1.3.0 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Aug 6, 2019

No description provided.

@roycaihw roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from micw523 and yliaog August 6, 2019 21:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2019
@roycaihw roycaihw force-pushed the minikube-1.15.1 branch 4 times, most recently from b0400cc to fee1dff Compare August 6, 2019 22:13
@roycaihw roycaihw changed the title [DO NOT MERGE] Switch minikube to use 1.15.1 [DO NOT MERGE] Switch to minikube 1.2.0 Aug 6, 2019
@micw523
Copy link
Contributor

micw523 commented Aug 8, 2019

I'm watching kubernetes/minikube#5014. I think we are running into the same problem.

@micw523
Copy link
Contributor

micw523 commented Aug 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@yliaog
Copy link
Contributor

yliaog commented Aug 8, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@roycaihw roycaihw changed the title [DO NOT MERGE] Switch to minikube 1.2.0 Temporary pin minikube to 1.2.0 due to regression in 1.3.0 Aug 8, 2019
@roycaihw roycaihw added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 8, 2019
@roycaihw
Copy link
Member Author

roycaihw commented Aug 8, 2019

Added a comment. Retagging

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roycaihw I believe such regressions will occure once in a while. I would remove v1.2.0 in favour of a variable, which for now can be set to 1.2 and late back to latest.

@k8s-ci-robot k8s-ci-robot merged commit b51037f into kubernetes-client:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants