-
Notifications
You must be signed in to change notification settings - Fork 1.6k
π (go/v4): Fix e2e test to validate that metrics are exported without asserting a controller-specific metric #5100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
camilamacedo86
merged 1 commit into
kubernetes-sigs:master
from
camilamacedo86:fix-e2e-test
Sep 14, 2025
Merged
π (go/v4): Fix e2e test to validate that metrics are exported without asserting a controller-specific metric #5100
camilamacedo86
merged 1 commit into
kubernetes-sigs:master
from
camilamacedo86:fix-e2e-test
Sep 14, 2025
+77
β70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b9d097
to
90d1c35
Compare
β¦a controller-specific metric
90d1c35
to
6862d03
Compare
c9018ef
into
kubernetes-sigs:master
30 of 36 checks passed
camilamacedo86
added a commit
that referenced
this pull request
Sep 22, 2025
* π± Bump github.com/onsi/gomega from 1.38.1 to 1.38.2 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.38.1 to 1.38.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.38.1...v1.38.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-version: 1.38.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * π Bump sigs.k8s.io/kubebuilder/v4 Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.7.1 to 4.8.0. - [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases) - [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md) - [Commits](v4.7.1...v4.8.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kubebuilder/v4 dependency-version: 4.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump github.com/onsi/ginkgo/v2 from 2.25.1 to 2.25.2 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.25.1 to 2.25.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.25.1...v2.25.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.25.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * β¨ feat: Upgrade controller-gen from v0.18.0 to v0.19.0 (#5064) feat: Upgrade controller-gen from v0.18.0 to v0.19.0 * β¨ Upgrade golang CI from v2.3.0 to v2.4.0 (#5063) Upgrade golang CI from v2.3.0 to v2.4.0 * β¨ feat: upgrade controller-runtime from v0.21.0 to v0.22.0 (#5062) feat: upgrade controller-runtime from v0.21.0 to v0.22.0 * (fix): Fix Docker builds failing when projects donβt include apis/, controllers/, or webhooks by updating .dockerignore to allow only Go source files and module metadata The make docker-build command no longer fails for new projects that don't yet have api/ or internal/ directories. What changed: - The Dockerfile now uses a general COPY . . command. - The .dockerignore file has been updated to filter the build context, ensuring only necessary files are included. * π Remove unit tests badge from README (#5067) Remove unit tests badge from README Removed the unit tests badge from the README. * π Bump github.com/spf13/pflag Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.7 to 1.0.10. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.7...v1.0.10) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-version: 1.0.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump github.com/onsi/ginkgo/v2 from 2.25.2 to 2.25.3 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.25.2 to 2.25.3. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.25.2...v2.25.3) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.25.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump actions/setup-node from 4 to 5 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump actions/setup-go from 5 to 6 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.9.1...v1.10.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-version: 1.10.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * docs: add note about Windows support The docs now inform users about the plans not to pursue native Windows support, and also provides instructions on how to set up Docker and kind on WSL2 for development on a Windows machine. * Fix Kubebuilder executable path for alpha generate. Fix Kubebuilder executable path not found for `kubebuilder alpha generate` command. * (chore): adjust comments on Auto Update workflow The comments for the `Run kubebuilder alpha update` step are now properly syntax-highlighted as such in yaml. The `--use-gh-models` flag is now properly referenced in the comments. * (helm/v1-alpha): Migrate from installCRDs=true to crds.enabled=true in GitHub action test-chart.yml The Helm chart flag installCRDs has been replaced with the community-standard crds.enabled. Update your GitHub action test-chart.ymlto ensure CRDs are installed during chart deployment. * (e2e) upgrade certmanager from v1.16.3 to v1.18.2 * (e2e/docs): upgrade prometheus version used to run the tests * go: upgraded github.com/spf13/pflag v1.0.9 => v1.0.10 * fix: handle empty CRD directories in Makefile install/uninstall - Gracefully no-op install/uninstall when no CRDs exist - Update sample Makefiles accordingly and add CI job to validate empty project - Revert Dockerfile and .dockerignore changes; keep templates and samples matching upstream * π± Bump golang.org/x/text from 0.28.0 to 0.29.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.28.0 to 0.29.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-version: 0.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump github.com/spf13/afero from 1.14.0 to 1.15.0 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-version: 1.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump helm.sh/helm/v3 from 3.18.6 to 3.19.0 Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.18.6 to 3.19.0. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.18.6...v3.19.0) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-version: 3.19.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * π± Bump golang.org/x/tools from 0.36.0 to 0.37.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * β¨ Upgrade controller-runtime from v0.22.0 to v0.22.1 (#5098) Upgrade controller-runtime from v0.22.0 to v0.22.1 * β¨ Upgrade kustomize from v5.6.0 to v5.7.1 (#5099) Upgrade kustomize from v5.6.0 to v5.7.1 * π (go/v4): Fix e2e test to validate that metrics are exported without asserting a controller-specific metric (#5100) Fix e2e test to validate that metrics are exported without asserting a controller-specific metric * (docs) drop patchStrategy/protobuf tags from Conditions in Getting Started section Followup of PR #4893 These tags are of no use for CRDs. They have their use in k8s core types in order to produce proper strategic merge patches, see https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/strategic-merge-patch.md but are superseded by +listType and +listMapKey in CRD world. Added `+listType`, `+listMapKey` and `+optional` markers to the example snippet * π (doc): Add demo for auto-update plugin (#5105) (doc): Add demo for auto-update plugin --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: Vitor Floriano <[email protected]> Co-authored-by: Ashish K Pathak <[email protected]> Co-authored-by: Obinna Odirionye <[email protected]> Co-authored-by: Predrag Knezevic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix e2e test to validate that metrics are exported without asserting a controller-specific metric.