Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: make all file headers consistent#4075

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
alexandear-org:chore/goheader
Feb 21, 2025
Merged

chore: make all file headers consistent#4075
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
alexandear-org:chore/goheader

Conversation

@alexandear
Copy link
Copy Markdown
Member

@alexandear alexandear commented Jan 28, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixes copyright headers for Go files and make it consistent. Integrates goheader linter to automatically check the file header.

Special notes for your reviewer:

Changes:

  • Add missing file headers.
  • Remove year.
  • Fix typos.

About goheader linter: https://golangci-lint.run/usage/linters/#goheader

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2025

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit bc363f7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67b75ead92f0920008cd2a55
😎 Deploy Preview https://deploy-preview-4075--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Jan 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2025
@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Jan 28, 2025 •
edited
Loading

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2025

LGTM label has been added.

DetailsGit tree hash: 8933e7facf8c998350ad3374258590a1f0e36e80

tenzen-y
tenzen-y reviewed Jan 28, 2025
View reviewed changes
Comment thread .golangci.yaml Outdated
@alexandear alexandear requested a review from tenzen-y January 29, 2025 13:16
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2025
@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Feb 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 6, 2025

LGTM label has been added.

DetailsGit tree hash: 1138571cdaf87a97628b6739a8f43f593b9d98a6

@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Feb 6, 2025

/retest

Due to #4113.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@alexandear alexandear marked this pull request as draft February 19, 2025 13:33
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@alexandear alexandear marked this pull request as ready for review February 20, 2025 16:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@PBundyra
Copy link
Copy Markdown
Contributor

PBundyra commented Feb 21, 2025

Thanks for the PR! Could we make goheader part of make verify?

@alexandear
Copy link
Copy Markdown
Member Author

alexandear commented Feb 21, 2025

Thanks for the PR! Could we make goheader part of make verify?

It's already part of make verify. The verify target executes the targets gomod-verify ci-lint fmt-verify shell-lint toc-verify manifests generate update-helm prepare-release-branch. The ci-lint target runs golangci-lint, which includes the goheader linter.

Or maybe you mean adding a new goheader-verify target that installs denis-tingaikin/go-header and then runs goheader separately from golangci-lint?

@PBundyra
Copy link
Copy Markdown
Contributor

PBundyra commented Feb 21, 2025

/lgtm
cc @tenzen-y

It's already part of make verify. The verify target executes the targets gomod-verify ci-lint fmt-verify shell-lint toc-verify manifests generate update-helm prepare-release-branch. The ci-lint target runs golangci-lint, which includes the goheader linter.

Great! Thanks for clarifying

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2025

LGTM label has been added.

DetailsGit tree hash: da65afcd73f5b114065e5c9486a8b689e27d5c3c

tenzen-y
tenzen-y reviewed Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit dcbcd61 into kubernetes-sigs:main Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Feb 21, 2025
@alexandear alexandear deleted the chore/goheader branch February 21, 2025 13:08
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
@alexandear @kannon92
chore: make all file headers consistent (kubernetes-sigs#4075)
519b195 
* chore: make all file headers consistent

* Remove year from copyright; use template-path
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
@alexandear @kannon92
chore: make all file headers consistent (kubernetes-sigs#4075)
2e452b6 
* chore: make all file headers consistent

* Remove year from copyright; use template-path
@alexandear alexandear mentioned this pull request Mar 17, 2026
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@PBundyra PBundyra Awaiting requested review from PBundyra

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@mbobrovskyi mbobrovskyi

@tenzen-y tenzen-y

@PBundyra PBundyra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v0.11

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandear @k8s-ci-robot @mbobrovskyi @PBundyra @tenzen-y