Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename metrics-certs to metrics-cert on the Kustomize configuration. #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

Rename metrics-certs to metrics-cert on the Kustomize configuration. #6345

merged 3 commits into from
Aug 1, 2025

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Aug 1, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Rename metrics-certs to metrics-cert on the Kustomize configuration.

Which issue(s) this PR fixes:

Prepare for #5929

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Rename kueue-metrics-certs to kueue-metrics-cert cert-manager.io/v1 Certificate name in cert-manager manifests when installing Kueue using the Kustomize configuration.

ACTION REQUIRED: If you're using cert-manager and have deployed Kueue using the Kustomize configuration, you must delete the existing kueue-metrics-certs cert-manager.io/v1 Certificate before applying the new changes to avoid conflicts.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 1, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit eb2f1b1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/688c6d77214144000855fa79

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2025
mbobrovskyi
mbobrovskyi commented Aug 1, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025
@mbobrovskyi mbobrovskyi mentioned this pull request Aug 1, 2025
Merged
@mbobrovskyi mbobrovskyi changed the title Rename metrics-cert to metrics-certs on Helm configuration. [Helm] Rename metrics-cert to metrics-certs on Helm configuration. Aug 1, 2025
@mbobrovskyi mbobrovskyi changed the title [Helm] Rename metrics-cert to metrics-certs on Helm configuration. [Helm] Rename metrics-cert to metrics-certs. Aug 1, 2025
@mbobrovskyi mbobrovskyi force-pushed the fix/rename-metrics-cert branch from 4290f1c to 7de2344 Compare August 1, 2025 07:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo @tenzen-y

@k8s-ci-robot k8s-ci-robot requested review from mimowo and tenzen-y August 1, 2025 07:04
@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

Can we consider to align kustomize with Helm without changing helm? Helm is the recommended way so I care about backward compatibility here more.

If we want to change helm, fair, but we need manual testing for the upgrade.
/hold
until manual testing for upgrade is done, or kustomize adjusted .

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Aug 1, 2025 •
edited
Loading

If we want to change helm, fair, but we need manual testing for the upgrade.

I tested it with Helm. The upgrade works fine, and Helm also removes the previous certificate.

kubectl get certificate.cert-manager.io -A
NAMESPACE      NAME                  READY   SECRET                      AGE
kueue-system   kueue-metrics-certs   True    kueue-metrics-server-cert   26m
kueue-system   kueue-serving-cert    True    kueue-webhook-server-cert   28m

But yes, maybe it's better to rename it to kueue-metrics-cert for consistency with kueue-serving-cert.

@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

Ok, just update the title and release note then accordingly

@mbobrovskyi mbobrovskyi changed the title [Helm] Rename metrics-cert to metrics-certs. Rename metrics-certs to metrics-cert on the Kustomize configuration. Aug 1, 2025
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Aug 1, 2025 •
edited
Loading

Ok, just update the title and release note then accordingly

/hold let me test this changes manually.

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Aug 1, 2025 •
edited
Loading

With the recent Kustomization changes, we're seeing certificate conflicts:

kubectl get certificate.cert-manager.io -A                      
NAMESPACE      NAME                  READY   SECRET                      AGE
kueue-system   kueue-metrics-cert    False   kueue-metrics-server-cert   21s
kueue-system   kueue-metrics-certs   True    kueue-metrics-server-cert   2m28s
kueue-system   kueue-serving-cert    True    kueue-webhook-server-cert   2m28s

The error in the conditions confirms the issue:

...
  status:
    conditions:
    - lastTransitionTime: "2025-08-01T11:40:05Z"
      message: Secret was issued for "kueue-metrics-certs". If this message is not
        transient, you might have two conflicting Certificates pointing to the same
        secret.
      observedGeneration: 1
      reason: IncorrectCertificate
      status: "False"
      type: Ready

To resolve this, users should manually delete the old kueue-metrics-certs Certificate to avoid conflicts.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 1, 2025
@mbobrovskyi
Copy link
Contributor Author

/retest

Due to #6227.

@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

Thank you for explaining. This makes sense, so the change is breaking, but only for users of kustomize.

I'm ok to make the change to align the kustomize and helm setups, it will make life much easier and allow for helm generation going forward.

I'm on the fence regarding cherry-picking. Maybe we can handle this as a "consistency bug" wdyt @tenzen-y ?

@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

/lgtm
/approve
/hold
in case @tenzen-y has extra comments

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc402d108124ea96b075c8b5044c3f731321c89d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@tenzen-y
Copy link
Member

tenzen-y commented Aug 1, 2025

Does Kueue using the Kustomize configuration mean https://github.com/kubernetes-sigs/kueue/tree/main/config?
Or does that include the released manifests as well?

@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

Maybe @mbobrovskyi can clarify, but I think the release manifests don't include the cert-manager config

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Aug 1, 2025 •
edited
Loading

Or does that include the released manifests as well?

No, the release manifests don't include the cert-manager config.

kueue/config/default/kustomization.yaml

Lines 29 to 30 in eb2f1b1

# [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'. 'WEBHOOK' components are required.
# - ../components/certmanager

@mbobrovskyi
Copy link
Contributor Author

Does Kueue using the Kustomize configuration mean https://github.com/kubernetes-sigs/kueue/tree/main/config?

Yes, that's what I meant.

@tenzen-y
Copy link
Member

tenzen-y commented Aug 1, 2025

Does Kueue using the Kustomize configuration mean https://github.com/kubernetes-sigs/kueue/tree/main/config?

Yes, that's what I meant.

Thank you for clarifying that. SGTM

tenzen-y
tenzen-y reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

tenzen-y commented Aug 1, 2025

@mbobrovskyi Do we need to cherry-pick this PR to release-0.12 and rerelase-0.13?

@mimowo
Copy link
Contributor

mimowo commented Aug 1, 2025

I would call it an inconsistency bug and cherrypick @tenzen-y

@tenzen-y
Copy link
Member

tenzen-y commented Aug 1, 2025

I would call it an inconsistency bug and cherrypick @tenzen-y

SGTM

/cherry-pick release-0.12
/cherry-pick release-0.13

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.12, release-0.13 in new PRs and assign them to you.

In response to this:

I would call it an inconsistency bug and cherrypick @tenzen-y

SGTM

/cherry-pick release-0.12
/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit ff136cc into kubernetes-sigs:main Aug 1, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Aug 1, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #6361

In response to this:

I would call it an inconsistency bug and cherrypick @tenzen-y

SGTM

/cherry-pick release-0.12
/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 1, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #6362

In response to this:

I would call it an inconsistency bug and cherrypick @tenzen-y

SGTM

/cherry-pick release-0.12
/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 1, 2025
Merged
@mbobrovskyi mbobrovskyi deleted the fix/rename-metrics-cert branch August 1, 2025 14:56
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Aug 11, 2025
@mbobrovskyi @kannon92
Rename metrics-certs to metrics-cert on the Kustomize configuration. (k…
106742c 
…ubernetes-sigs#6345)

* Rename metrics-cert to metrics-certs.

* Revert "Rename metrics-cert to metrics-certs."

This reverts commit 7de2344.

* Rename metrics-certs to metrics-cert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@PBundyra PBundyra Awaiting requested review from PBundyra

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
5 participants
@mbobrovskyi @mimowo @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot