Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CrashLoopBackOff when using config/alpha-enabled. #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

Fix CrashLoopBackOff when using config/alpha-enabled. #6670

merged 1 commit into from
Aug 26, 2025

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Aug 26, 2025 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix CrashLoopBackOff when using config/alpha-enabled and missing AdmissionFairSharing config.

Which issue(s) this PR fixes:

Fixes #6663

Special notes for your reviewer:

Does this PR introduce a user-facing change?

AFS: Fixed kueue-controller-manager crash when enabled AdmissionFairSharing feature gate without AdmissionFairSharing config.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 26, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit d442c2f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68ad78e5a90f48000813f29b

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2025
@mbobrovskyi
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 26, 2025
@abhijeet-dhumal
Copy link
Contributor

@mbobrovskyi @kannon92
Please correct me here but as now we are setting AllAlpha = true resulting in AdmissionFairSharing feature enabled by default, is it ok to uncomment Admission Fair Sharing config here ? : kueue-manager-config

admissionFairSharing:
  usageHalfLifeTime: "168h"
  usageSamplingInterval: "5m"
  resourceWeights:
    cpu: 1
    memory: 1

@mbobrovskyi
Copy link
Contributor Author

@mbobrovskyi @kannon92 Please correct me here but as now we are setting AllAlpha = true resulting in AdmissionFairSharing feature enabled by default, is it ok to uncomment Admission Fair Sharing config here ? : kueue-manager-config

admissionFairSharing:
  usageHalfLifeTime: "168h"
  usageSamplingInterval: "5m"
  resourceWeights:
    cpu: 1
    memory: 1

This is an example. I don't think so we need to uncomment it.

@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg

@k8s-ci-robot k8s-ci-robot requested a review from IrvingMg August 26, 2025 08:40
tenzen-y
tenzen-y reviewed Aug 26, 2025
View reviewed changes
@mbobrovskyi mbobrovskyi force-pushed the fix/crash-loop-back-off-when-using-alpha-enabled branch from ce80815 to d442c2f Compare August 26, 2025 09:05
@mbobrovskyi mbobrovskyi requested a review from tenzen-y August 26, 2025 09:06
tenzen-y
tenzen-y reviewed Aug 26, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

pkg/scheduler/scheduler.go
log.V(2).Info("Workload assumed in the cache")

if features.Enabled(features.AdmissionFairSharing) {
if s.admissionFairSharing != nil && features.Enabled(features.AdmissionFairSharing) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a follow-up comment. @mbobrovskyi Could you implement the following util function in https://github.com/kubernetes-sigs/kueue/tree/d442c2f6c9ae433c2dfeda305d51b04b513c73a4/pkg/util/admissionfairsharing, then check if AFS is enabled in everywhere?

func EnabledAfs(afsConfig config.AdmissionFairSharing) bool {
    return afsConfig != nil && features.Enabled(features.AdmissionFairSharing)
}

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e00d4fb9ef83f805e906eeba2871e7784889dd52

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025
@tenzen-y
Copy link
Member

/release-note-edit

AFS: Fixed kueue-controller-manager crash when enabled AdmissionFairSharing feature gate without AdmissionFairSharing config.

@tenzen-y
Copy link
Member

/cherry-pick release-0.13

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 99b9a12 into kubernetes-sigs:main Aug 26, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Aug 26, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #6671

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 26, 2025
Merged
@mbobrovskyi mbobrovskyi deleted the fix/crash-loop-back-off-when-using-alpha-enabled branch August 26, 2025 09:41
@mbobrovskyi mbobrovskyi mentioned this pull request Aug 26, 2025
Merged
@mimowo mimowo mentioned this pull request Sep 30, 2025
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.

CrashLoopBackOff when using config/alpha-enabled due to missing AdmissionFairSharing config
5 participants
@mbobrovskyi @abhijeet-dhumal @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot