Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Smuger
Copy link
Contributor

@Smuger Smuger commented Aug 27, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • KueueViz frontend and backend Ingresses previously had hardcoded NGINX annotations.
    • This PR allows you to set your own annotations in Helm's values.yaml, with NGINX as the default. You can for example disable nginx.ingress.kubernetes.io/ssl-redirect: "true"
  • KueueViz frontend and backend Ingresses also previously had hardcoded TLS.
    • This PR allows you to use HTTP, which can be important for users who terminate TLS on AWS ALB.
  • The KueueViz backend deployment didn't expose environment variables.
    • This PR allows you to set, for example, KUEUEVIZ_ALLOWED_ORIGINS from values.yaml.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I'm setting KUEUEVIZ_ALLOWED_ORIGINS to "frontend.kueueviz.local" by default. Let me know if there is a better option.
image

Does this PR introduce a user-facing change?

KueueViz: Enhancing the following endpoint customizations and optimizations:
- The frontend and backend ingress no longer have hardcoded NGINX annotations. You can now set your own annotations in Helm’s values.yaml using kueueViz.backend.ingress.annotations and kueueViz.frontend.ingress.annotations
- The Ingress resources for KueueViz frontend and backend no longer require hardcoded TLS. You can now choose to use HTTP only by not providing kueueViz.backend.ingress.tlsSecretName and kueueViz.frontend.ingress.tlsSecretName
- You can set environment variables like KUEUEVIZ_ALLOWED_ORIGINS directly from values.yaml using kueueViz.backend.env

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 27, 2025
Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 121624f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68cc343ec6f6970008d3c6e2

Copy link

linux-foundation-easycla bot commented Aug 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Smuger / name: Krzysztof Kwietniewski (121624f)

@k8s-ci-robot
Copy link
Contributor

Welcome @Smuger!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Smuger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2025
@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2025
@Smuger Smuger force-pushed the kueueviz-dynamic-annotations-and-tls branch from 0104c99 to f6bc463 Compare September 1, 2025 11:18
@Smuger
Copy link
Contributor Author

Smuger commented Sep 1, 2025

/retest

@Smuger
Copy link
Contributor Author

Smuger commented Sep 1, 2025

@mbobrovskyi
Thanks for approving the tests. It's all green now 🎉

@Smuger
Copy link
Contributor Author

Smuger commented Sep 4, 2025

/area dashboard

@k8s-ci-robot k8s-ci-robot added the area/dashboard Denotes a PR that is related to the built-in dashboard label Sep 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Sep 12, 2025

@mbobrovskyi
could you give it a pass? Seems like a useful feature

Comment on lines -7 to -9
annotations:
nginx.ingress.kubernetes.io/rewrite-target: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that Helm charts aren't needed, but can we create a patch to retain it in the manifests?

Copy link
Contributor

@mbobrovskyi mbobrovskyi Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, revert the config changes and just update the annotations in the charts.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbobrovskyi
Sorry, I'm not sure if I understand. nginx annotations are still the default in values.yaml. Are you suggesting keeping the hardcoded nginx annotations in config and then overwriting them from values.yaml? I'm a bit worried about the added complexity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you configured the default value for the Helm charts — that’s good. But what about the Kustomize manifests? Many users install Kueue using manifests instead of Helm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the difference between manifests using make artifacts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbobrovskyi
Thanks, I get it now. Kustomize patch added

env: []
asserts:
- notExists:
path: spec.template.spec.containers[0].env[0]
Copy link
Contributor

@mbobrovskyi mbobrovskyi Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add empty line at the end of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbobrovskyi
Added empty line

Comment on lines +225 to +228
# -- Environment variables for KueueViz backend deployment
env:
- name: KUEUEVIZ_ALLOWED_ORIGINS
value: "frontend.kueueviz.local"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the same for frontend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbobrovskyi
Added environment variables for frontend

@Smuger
Copy link
Contributor Author

Smuger commented Sep 15, 2025

/test all

@Smuger Smuger force-pushed the kueueviz-dynamic-annotations-and-tls branch from 8d2dfdd to 0f6f140 Compare September 15, 2025 14:42
@k8s-ci-robot
Copy link
Contributor

@Smuger: The following commands are available to trigger required jobs:

/test pull-kueue-build-image-main
/test pull-kueue-test-e2e-certmanager-main
/test pull-kueue-test-e2e-customconfigs-main
/test pull-kueue-test-e2e-kueueviz-main
/test pull-kueue-test-e2e-main-1-31
/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-e2e-main-1-33
/test pull-kueue-test-e2e-main-1-34
/test pull-kueue-test-e2e-multikueue-main
/test pull-kueue-test-e2e-tas-main
/test pull-kueue-test-integration-baseline-main
/test pull-kueue-test-integration-extended-main
/test pull-kueue-test-integration-multikueue-main
/test pull-kueue-test-scheduling-perf-main
/test pull-kueue-test-unit-main
/test pull-kueue-verify-main

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


patches:
# Add ingress annotations for nginx backend ingress controller
- path: backend_ingress_annotations_patch.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about frontend ingress?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added patch for frontend ingress

- name: frontend
env:
- name: REACT_APP_WEBSOCKET_URL
value: 'wss://backend.kueueviz.local' No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line added

# Add ingress annotations for nginx backend ingress controller
- path: backend_ingress_annotations_patch.yaml
# Add environment variables for frontend deployment
- path: frontend_deployment_env_patch.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tls changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tls patch

@mimowo
Copy link
Contributor

mimowo commented Sep 18, 2025

/approve
/cherrypick release-0.13
/cherrypick release-0.12
Leaving lgtm to @mbobrovskyi

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.12, release-0.13 in new PRs and assign them to you.

In response to this:

/approve
/cherrypick release-0.13
/cherrypick release-0.12
Leaving lgtm to @mbobrovskyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, Smuger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
imagePullSecrets: []
# -- Enable PriorityClass for KueueViz dashboard backend deployments
priorityClassName:
# -- Environment variables for KueueViz backend deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# -- Environment variables for KueueViz backend deployment
# -- Environment variables for KueueViz frontend deployment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you mean the error here env frontend
Sorry for such a silly miss. Fixed

| enableVisibilityAPF | bool | `false` | Enable API Priority and Fairness configuration for the visibility API |
| fullnameOverride | string | `""` | Override the resource name |
| kubernetesClusterDomain | string | `"cluster.local"` | Kubernetes cluster's domain |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz frontend deployment |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"backend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |

It look like still not correct. Could you please take a look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be completly wrong so do let me know if I'm misunderstanding this.

Isn't setting env variable of backend deployment KUEUEVIZ_ALLOWED_ORIGINS to "frontend.kueueviz.local" correct? I can set it back to '*' if you want

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, wdyt @mbobrovskyi ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see.

…ined in Helm values; Add environment variables via values.yaml in frontend and backend deployment; kustomize patch ingress annotations and frontend deployment environment variables
@Smuger Smuger force-pushed the kueueviz-dynamic-annotations-and-tls branch from f1249b8 to 121624f Compare September 18, 2025 16:33
@mbobrovskyi
Copy link
Contributor

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f867f5dae8c80a852d506270dc22ee38bde9661

@k8s-ci-robot k8s-ci-robot merged commit dd9f505 into kubernetes-sigs:main Sep 22, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Sep 22, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #6934

In response to this:

/approve
/cherrypick release-0.13
/cherrypick release-0.12
Leaving lgtm to @mbobrovskyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: #6682 failed to apply on top of branch "release-0.12":

Applying: Allow annotations for Kueueviz frontend and backend ingress to be defined in Helm values; Add environment variables via values.yaml in frontend and backend deployment; kustomize patch ingress annotations and frontend deployment environment variables
.git/rebase-apply/patch:190: trailing whitespace.
            annotations: 
.git/rebase-apply/patch:236: trailing whitespace.
            annotations: 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	charts/kueue/README.md
M	charts/kueue/templates/kueueviz/backend-deployment.yaml
M	charts/kueue/templates/kueueviz/backend-ingress.yaml
M	charts/kueue/templates/kueueviz/frontend-deployment.yaml
M	charts/kueue/templates/kueueviz/frontend-ingress.yaml
A	charts/kueue/tests/kueue_test.yaml
M	charts/kueue/values.yaml
M	config/components/kueueviz/frontend-deployment.yaml
M	hack/processing-plan.yaml
Falling back to patching base and 3-way merge...
Auto-merging hack/processing-plan.yaml
CONFLICT (content): Merge conflict in hack/processing-plan.yaml
Auto-merging config/components/kueueviz/frontend-deployment.yaml
CONFLICT (content): Merge conflict in config/components/kueueviz/frontend-deployment.yaml
Auto-merging charts/kueue/values.yaml
CONFLICT (content): Merge conflict in charts/kueue/values.yaml
CONFLICT (modify/delete): charts/kueue/tests/kueue_test.yaml deleted in HEAD and modified in Allow annotations for Kueueviz frontend and backend ingress to be defined in Helm values; Add environment variables via values.yaml in frontend and backend deployment; kustomize patch ingress annotations and frontend deployment environment variables. Version Allow annotations for Kueueviz frontend and backend ingress to be defined in Helm values; Add environment variables via values.yaml in frontend and backend deployment; kustomize patch ingress annotations and frontend deployment environment variables of charts/kueue/tests/kueue_test.yaml left in tree.
Auto-merging charts/kueue/templates/kueueviz/frontend-ingress.yaml
CONFLICT (content): Merge conflict in charts/kueue/templates/kueueviz/frontend-ingress.yaml
Auto-merging charts/kueue/templates/kueueviz/frontend-deployment.yaml
CONFLICT (content): Merge conflict in charts/kueue/templates/kueueviz/frontend-deployment.yaml
Auto-merging charts/kueue/templates/kueueviz/backend-ingress.yaml
CONFLICT (content): Merge conflict in charts/kueue/templates/kueueviz/backend-ingress.yaml
Auto-merging charts/kueue/templates/kueueviz/backend-deployment.yaml
Auto-merging charts/kueue/README.md
CONFLICT (content): Merge conflict in charts/kueue/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Allow annotations for Kueueviz frontend and backend ingress to be defined in Helm values; Add environment variables via values.yaml in frontend and backend deployment; kustomize patch ingress annotations and frontend deployment environment variables

In response to this:

/approve
/cherrypick release-0.13
/cherrypick release-0.12
Leaving lgtm to @mbobrovskyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor

mimowo commented Sep 22, 2025

@Smuger we cherrypicked for 0.13 using the robot, but there are conflicts on 0.12. If you want to cherrypick there the PR needs to be prepared manually. Otherwise we can just skip CP to 0.12.

| enableVisibilityAPF | bool | `false` | Enable API Priority and Fairness configuration for the visibility API |
| fullnameOverride | string | `""` | Override the resource name |
| kubernetesClusterDomain | string | `"cluster.local"` | Kubernetes cluster's domain |
| kueueViz.backend.env | list | `[{"name":"KUEUEVIZ_ALLOWED_ORIGINS","value":"frontend.kueueviz.local"}]` | Environment variables for KueueViz backend deployment |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this .local top level domain is a bit dangerous since .local is reserved by mDNS usage and some ecosystem rely on that like zeroConf.

I hope that no one deploys this default value to their production.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitly like to avoid this. I was unsure how to handle KUEUEVIZ_ALLOWED_ORIGINS from the start.

Should I set KUEUEVIZ_ALLOWED_ORIGINS in values.yaml to "" and let middleware inform the user that they need to explicilty set it in production?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was KUEUEVIZ_ALLOWED_ORIGINS set before this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y can you clarify why this is dangerous? Do you mean (1.) someone could hack KueueViz if deployed this way, or that (2.) it wouldn't work for environments not using "local".

IIUC it may not work on some environements, and require manual change, but so would empty "" also not work. In that case it seems fair to leave it using "local" as a default. wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming (2.) - no attack risk, just "doesn't work", I'm ok to either leave it empty or set as frontend.kueueviz.local

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1Q: In my opinion we should handle CORS like this
Development:
Should be set to: KUEUEVIZ_ALLOWED_ORIGINS = "*" by default making every origin valid
Production:
Should be set to KUEUEVIZ_ALLOWED_ORIGINS = "" by default making no origin valid. Expecting user to setup
their own domain

I'm ok with that in a follow up.

2Q I'm also for removing .local domain.

I'm ok for that in a follow up too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1A: Specifying a dedicated CORS domain should be better in the production env. If not, some security risks occur like CSRF and XSS.

Yes, so it is better not to use *. Actually * was used before this PR.

IIUC, the * CORS origin is used only when development mode. So, I think that it is not bigger problem.

2A: .local domain is a reserved name. So, if we use this domain here, sometimes the intranet will break based on their network settings.

Yes, but if this is the case admins will be able to change. If this works in most setups maybe no need to change the default. It does not seem to have any risk - it may just not work.

I meant the affection potentially could reach across their entire internal networks. So, I mentioned that "I hope ... this default value to their production."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1Q: In my opinion we should handle CORS like this
Development:
Should be set to: KUEUEVIZ_ALLOWED_ORIGINS = "*" by default making every origin valid
Production:
Should be set to KUEUEVIZ_ALLOWED_ORIGINS = "" by default making no origin valid. Expecting user to setup their own domain

2Q I'm also for removing .local domain.
Should we just use localhost by default and tell people to use port-forwarding? Kubernetes-Dashboard does that

https://github.com/kubernetes/dashboard/blob/1d1d9f436f5def9f6a3a4f33757eed5175c53649/charts/kubernetes-dashboard/values.yaml#L105

https://github.com/kubernetes/dashboard/blob/1d1d9f436f5def9f6a3a4f33757eed5175c53649/charts/kubernetes-dashboard/templates/networking/ingress.yaml#L69

@Saumya40-codes Thanks for summarizing that. Both look good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the * CORS origin is used only when development mode. So, I think that it is not bigger problem.

I think this "developer" more is actually what we were releasing in 0.13 by default TBH. So, I think this PR making it "frontend.kueueviz.local" is making this more strict anyway.

I meant the affection potentially could reach across their entire internal networks. So, I mentioned that "I hope ... this default value to their production."

Can you clarify what you mean by that?

Basically, I think KueueViz needs to work OOTB just by enableKueueViz, otherwise users will hit issues.

So IIUC "frontend.kueueviz.local" is very useful as default setting. Sure, we can educate users they recommend changing (I'm still don't understand why / how).

Similarly, we recommend users to use HA mode for Kueue, but at least it works OOTB, I think we need to make KueueViz also works OOTB.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to make KueueViz OOTB, * could be used as a default parameter with development mode.
But, if we want to make KueueViz deployable to production, avoiding both * and .local would be better.

Both * and .local have the same risk "level", but the "directions" are different.
* indicates security risk, .local indicates network disruption risk.
We might consider the .localhost domain, but we're not sure if it works correctly.

To be clear, my comment is "hope" for production. So, I don't try to enforce any approach. Some solutions are safe, but others are inconvenient.

@tenzen-y
Copy link
Member

/release-note-edit

KueueViz: Enhancing the following endpoint customizations and optimizations:
- The frontend and backend ingress no longer have hardcoded NGINX annotations. You can now set your own annotations in Helm’s values.yaml using kueueViz.backend.ingress.annotations and kueueViz.frontend.ingress.annotations
- The Ingress resources for KueueViz frontend and backend no longer require hardcoded TLS. You can now choose to use HTTP only by not providing kueueViz.backend.ingress.tlsSecretName and kueueViz.frontend.ingress.tlsSecretName
- You can set environment variables like KUEUEVIZ_ALLOWED_ORIGINS directly from values.yaml using kueueViz.backend.env

@mimowo mimowo mentioned this pull request Sep 30, 2025
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dashboard Denotes a PR that is related to the built-in dashboard cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants