Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add priority_class label for kueue_local_queue_evicted_workloads_total metric. #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

Add priority_class label for kueue_local_queue_evicted_workloads_total metric. #6898

merged 2 commits into from
Sep 26, 2025

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Sep 17, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add priority_class label for kueue_local_queue_evicted_workloads_total metric.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added priority_class label for kueue_local_queue_evicted_workloads_total metric

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit c93cf84
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68d6aa0f30f42e00085ea809
😎 Deploy Preview https://deploy-preview-6898--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 17, 2025
@vladikkuzn
Copy link
Contributor Author

/assign
/ok-to-test
/cc @mbobrovskyi
/test all

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 17, 2025
@vladikkuzn vladikkuzn changed the title metrics: add workload_priority_class to kueue_local_queue_evicted_wor… Add workload_priority_class label for kueue_local_queue_evicted_workloads_total metric. Sep 17, 2025
@mbobrovskyi mbobrovskyi mentioned this pull request Sep 18, 2025
Closed
3 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_evicted_workloads_total branch 2 times, most recently from 636812a to 10ac225 Compare September 26, 2025 08:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2025
@mbobrovskyi
Copy link
Contributor

/retitle Add priority_class label for kueue_local_queue_evicted_workloads_total metric.

@k8s-ci-robot k8s-ci-robot changed the title Add workload_priority_class label for kueue_local_queue_evicted_workloads_total metric. Add priority_class label for kueue_local_queue_evicted_workloads_total metric. Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_evicted_workloads_total branch from 10ac225 to 8734695 Compare September 26, 2025 10:01
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2025
@vladikkuzn vladikkuzn marked this pull request as ready for review September 26, 2025 10:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 26, 2025
@mbobrovskyi
Copy link
Contributor

@vladikkuzn could you please rebase?

@mbobrovskyi
Copy link
Contributor

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b6a42f6054b5db2f64ca47e609e43cd020cf94b

@mbobrovskyi
Copy link
Contributor

/cc @mimowo

@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_evicted_workloads_total branch from 797ae98 to 146eccb Compare September 26, 2025 14:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@mbobrovskyi
Copy link
Contributor

@vladikkuzn Could you please fix linter?

@mbobrovskyi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0f7d9a34e413a917d24eef75ae071074eb46eab7

mbobrovskyi
mbobrovskyi reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Please also update site.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2025
@vladikkuzn vladikkuzn force-pushed the kueue_local_queue_evicted_workloads_total branch from 146eccb to c93cf84 Compare September 26, 2025 14:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@mimowo
Copy link
Contributor

mimowo commented Sep 26, 2025

/approve
Leaving lgtm and unhold to @mbobrovskyi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025
@mbobrovskyi
Copy link
Contributor

/lgtm
/unhold

Thank you!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f2743c643214b564b888ac6bb07b246bf7513cdb

@k8s-ci-robot k8s-ci-robot merged commit 9c25635 into kubernetes-sigs:main Sep 26, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Sep 26, 2025
@mbobrovskyi mbobrovskyi deleted the kueue_local_queue_evicted_workloads_total branch September 26, 2025 15:29
@mimowo
Copy link
Contributor

mimowo commented Sep 30, 2025

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2025
@mimowo mimowo mentioned this pull request Sep 30, 2025
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo Awaiting requested review from mimowo

@kannon92 kannon92 Awaiting requested review from kannon92

@gabesaba gabesaba Awaiting requested review from gabesaba

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@mbobrovskyi mbobrovskyi

@vladikkuzn vladikkuzn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@vladikkuzn @k8s-ci-robot @mbobrovskyi @mimowo