Running L3AFD in a Docker container #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aka320 <[email protected]>
- Updating README with the instructions to Build L3AFD Docker image and run it in a Container. Signed-off-by: aka320 <[email protected]>
pmoroney
previously approved these changes
May 29, 2024
pmoroney
left a comment
There was a problem hiding this comment.
LGTM, although it does sound like a good idea to pin the hash for the docker file as suggested by the security bot.
sanfern
requested changes
May 29, 2024
README.md
Outdated
| # Generate Swagger Docs | ||
| See our [Swaggo setup](docs/swagger.md) | ||
|
|
||
| # Build L3AFD Docker image |
Contributor
There was a problem hiding this comment.
Move this block in building section
build-docker/Dockerfile
Outdated
Comment on lines
19
to
26
| vim \ | ||
| wget \ | ||
| curl \ | ||
| linux-tools-generic \ | ||
| net-tools \ | ||
| iproute2 \ | ||
| elfutils \ | ||
| libjson-c-dev \ |
- Fixing indentation in Dockerfile - Using specific SHA for Jammy base docker image - Cosmetic changes for README.md Signed-off-by: aka320 <[email protected]>
roopeshsn
pushed a commit
to roopeshsn/l3afd
that referenced
this pull request
Mar 8, 2025
* Create Dockerfile for L3AFD Signed-off-by: aka320 <[email protected]> * Update README.md - Updating README with the instructions to Build L3AFD Docker image and run it in a Container. Signed-off-by: aka320 <[email protected]> * Addressing review comments - Fixing indentation in Dockerfile - Using specific SHA for Jammy base docker image - Cosmetic changes for README.md Signed-off-by: aka320 <[email protected]> --------- Signed-off-by: aka320 <[email protected]> Signed-off-by: Roopesh Saravanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing