This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Rewrite scheduler to avoid HoL blocking #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unique constraint
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 48.61% 48.92% +0.31%
==========================================
Files 52 52
Lines 8276 8316 +40
==========================================
+ Hits 4023 4069 +46
+ Misses 4253 4247 -6
Continue to review full report at Codecov.
|
* scheduler.types.KernelInfo now takes agent binding info, which may be null if not bound yet
* This is not a strict FIFO, but will reduce many customer complaints...
* Use config/plugins/scheduler/fifo/num_retries_to_skip etcd key.
fix: Remove debug print
achimnol
added a commit
that referenced
this pull request
Apr 7, 2021
* db: Add alembic migration to add KernelStatus.SCHEDULED and fix up the unique constraint * fix: Split the async tasks for session scheduling into two separate "scheduling" + "preparation" loops * refactor: Make PendingSession/ExistingSession queries composable * test: Update scheduler test cases * feat: Skip the session with specific number of retries in FIFO scheduler - This is not a strict FIFO, but will reduce many customer complaints... - Use `config/plugins/scheduler/fifo/num_retries_to_skip` etcd key. Backported-From: main Backported-To: 21.03
achimnol
added a commit
that referenced
this pull request
Apr 7, 2021
* db: Add alembic migration to add KernelStatus.SCHEDULED and fix up the unique constraint * fix: Split the async tasks for session scheduling into two separate "scheduling" + "preparation" loops * refactor: Make PendingSession/ExistingSession queries composable * test: Update scheduler test cases * feat: Skip the session with specific number of retries in FIFO scheduler - This is not a strict FIFO, but will reduce many customer complaints... - Use `config/plugins/scheduler/fifo/num_retries_to_skip` etcd key. Backported-From: main Backported-To: 20.09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ticket: OP#1157