-
Notifications
You must be signed in to change notification settings - Fork 38
Documentation updates and fixes #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(apparently I started a review instead of leaving individual comments...?? Sorry if this makes it confusing)
9ed1731
to
53712ea
Compare
Now that labscript-suite/labscript-utils#38 allows the profile directory to exist when running |
I'm in favour of using the profile directory for the recommended venv and dev install. |
We are mixing unix and Windows quick start command line instructions. Should we stick to one? |
How about we recommend users add our anaconda channel rather than adding the channel name to install commands?
|
I don't think we should waste the space on both. I suggest windows only - it's the most likely OS to be used due to drivers. Also Linux users should be adept enough to translate the commands to Linux, but I doubt the reverse is necessarily true. I also have a plan to see if I can add some Javascript to the quickstart section of the developer install to allow people to generate the command for their forks so that they don't have to find/replace the github username. This could potentially also change the line continuation character for a selected OS. It'll be harder to integrate that if we start double up on example code for multiple platforms.
How does this play out if people want to take dependencies from other channels that they've also added. Which takes precedence? Does specifying the channel at install time change the channel precedence vs adding it as a channel to the whole environment? |
Also, was there a reason for changing the conda env name from |
Yep! I'm all for this per @philipstarkey's comment above about Windows being the lowest common denominator (I'm paraphrasing, and I don't mean this with any disparaing/condescending connotations).
I think that would fit into the documentation category of programmers enumerating all of the permutations to a fault, especially in this instance as the differences are minor. |
Isn't this moot, since we strongly recommend users create a dedicated conda environment for the labscripte suite? Why then would they want to take dependencies from other channels? |
Naming the conda environment
|
Their labscript/lyse usercode may depend on 3rd party packages (e.g. optimisation routines) and that code currently runs in the same Python environment.
Those are good points that I hadn't considered. Probably best to leave it as py38 then. Maybe we can just double check that we're consistently emphasising that the environment should only be used for labscript suite related things? |
Sounds good. Windows command-line syntax it is then.
Conda's default behaviour is to prefer channels by priority, and then by version number of the package. Channel priority can be controlled by different ways of spelling FWIW though I've discovered that
This should probably be how this line is spelled even if one is using the base conda environment, as I argue in favour of in #45 |
*Coming soon!* | ||
$ source .venv/bin/activate | ||
(.venv) $ pip install \ | ||
--src . -e git+https://github.com/wkheisenberg/blacs#egg=blacs \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fictitious GitHub user is not so fictitious 😕
Let's merge and make further changes on top. |
Drop local version.sphinx.ext.autosectionlabel
extension withautosectionlabel_prefix_document=True
to prefix each automatically-created section label with the name of the document it is in and a colon, e.g.labscript_suite_py38
as this name is used in the shortcut suffix by desktop-app, and thelabscript_suite_
prefix is inessential.Preview changes here: https://rpanderson-labscriptsuite.readthedocs.io