Remove code specific to building with setuptools_conda #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest setuptools_conda, this is not necessary - the dist_conda command is available without having to explicitly declare it in setup.py, and the file path issue was sorted out by having setuptools_conda build wheels as an intermediate, more closely matching what a pip install does (this is the most commonly used way to build conda packages anyway, so it's what setuptools_conda should have been doing all along) Also, setuptools_conda introspects python versions from package classifiers, so that doesn't need to be declared.
rpanderson
reviewed
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest setuptools_conda, this is not necessary - the dist_conda
command is available without having to explicitly declare it in
setup.py, and the file path issue was sorted out by having
setuptools_conda build wheels as an intermediate, more closely matching
what a pip install does (this is the most commonly used way to build
conda packages anyway, so it's what setuptools_conda should have been
doing all along)
Also, setuptools_conda introspects python versions from package
classifiers, so that doesn't need to be declared.