Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(sec): randomString bias #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2023
Merged

fix(sec): randomString bias #2492

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92971b5
fix(sec): `randomString` bias
trim21 Jul 21, 2023
f32da2e
Update util.go
trim21 Jul 21, 2023
68f8af3
Update util.go
trim21 Jul 21, 2023
1c89a88
use pooled buffed random reader
trim21 Jul 21, 2023
4585ec2
Update util.go
trim21 Jul 21, 2023
479045b
Update util.go
trim21 Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update util.go
  • Loading branch information
@trim21
trim21 committed Jul 21, 2023
commit 4585ec222efde07a2c7a97fb1ad6f0a9b7aef3f4
1 change: 1 addition & 0 deletions middleware/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ func matchSubdomain(domain, pattern string) bool {
return false
}

// https://tip.golang.org/doc/go1.19#:~:text=Read%20no%20longer%20buffers%20random%20data%20obtained%20from%20the%20operating%20system%20between%20calls
var randomReaderPool = sync.Pool{New: func() any {
return bufio.NewReader(rand.Reader)
}}
Expand Down