Username & InventoryViewer Improvement #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 1-space blank when prefix or suffix is defined with blank
…est and moved item at same time), Now catches Ender chest in any language with using TextComponentTranslation.key instead of name(This method needed to use SPacketOpenWindow.
|
thanks for your contribution :) can you allow maintainers to push on your branch? i wanna push smol refactoring |
|
Well I'm sorry for saying this but how can i allow it? I'm really new wth this type of job |
Avanatiker
approved these changes
Aug 6, 2022
|
That's the most professional first pull request i've ever seen. Hats off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Username fix
Improved InventoryViewer, especially enderchest part.
Describe how this pull is helpful
better Performance
Additional context
well It's the first time that i'm opening the pull request, idk am i doing right but anyways
and I couldn't find the part that could cause bug but didn't test on high-ping(i don't know the high-ping environment has a potential power that could cause error, but anyways)