Changed the DiscordRPC delay from seconds to ms #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you messed up your conversion. If you want milliseconds you have to remove the multiplier. You could use half seconds. If you coded that in. |
|
feel free to fix it and make a better pull for this, I don't really know what I'm doing lmfao |
|
I can. You would need to give me r+w access (or I would have to make a pull request). Also you would have to tell me how you want it set up. |
|
Minimum value, max value, format(seconds or milliseconds), and default value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Changed the DiscordRPC delay from seconds to ms
Describe how this pull is helpful
Much better to have it in ms, as seconds are a rather large unit of measurement. And 60 seconds of delay max would have RPC time out. Now, it goes from a minimum of 200 ms, to a max of 2000ms, preventing too much delay that it times out, but ensuring that even though it has the option to minimize delay at 200ms, it does not spam the RPC either.
Additional context
none