✨ Open GitLab merge request page #15

kitagry · 2024-03-17T06:52:48Z

Add GitLab pull request URL

Summary by CodeRabbit

New Features
- Introduced an optional method to extract Pull Request ID from commit messages across different hosting services.
- Enhanced functionality to retrieve Pull Request URLs and IDs for GitLab-hosted repositories.
- Updated the pull_request_url.ts code to incorporate the new hostingService parameter for extracting Pull Request IDs.

coderabbitai · 2024-03-17T06:52:55Z

Walkthrough

The recent update introduces a new optional method extractPullRequestID to the HostingService interface, enhancing the ability to interact with commit messages by extracting pull request IDs. This functionality is now supported in both GitHub and GitLab services. Additionally, the process of obtaining pull request URLs has been refined by incorporating the new method, ensuring a more seamless integration and retrieval process across different hosting services.

Changes

Files	Change Summary
`hosting_service/mod.ts`, `.../github_com.ts`, `.../gitlab_com.ts`	Added `extractPullRequestID` method to `HostingService` for extracting PR ID from commit messages and enhanced PR ID extraction and URL retrieval methods.
`pull_request_url.ts`	Updated to extract PR ID using the new `hostingService` parameter.

🐇✨
In the land of code, where the bits do roam,
There came an update, a new method to home.
Pull requests and commits, now easier to find,
With a hop and a skip, leaving confusion behind.
🌟📜 From GitHub to GitLab, the changes do spread,
In the world of development, we're now well ahead.
🐾💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5808b72 and e5809eb.

Files selected for processing (4)

hosting_service/mod.ts (1 hunks)
hosting_service/services/github_com.ts (1 hunks)
hosting_service/services/gitlab_com.ts (1 hunks)
pull_request_url.ts (6 hunks)

Additional comments: 5

hosting_service/mod.ts (1)

34-36: The addition of the extractPullRequestID method to the HostingService interface is a valuable enhancement for extending pull request handling capabilities. It's important to ensure that implementing classes are aware of this new optional method and handle its absence appropriately.

Consider adding documentation or guidelines for implementers on how to effectively utilize this new method, especially in cases where extracting a PR ID is not feasible or relevant.

hosting_service/services/github_com.ts (1)

54-59: The implementation of extractPullRequestID for GitHub is well-aligned with the objectives of enhancing pull request handling. It's tailored to GitHub's merge commit message format, which is appropriate.

Consider adding a comment detailing the expected format of the commit message this function is designed to parse. This can aid future maintainers in understanding the context and limitations of this implementation.

hosting_service/services/gitlab_com.ts (2)

44-51: The implementation of getPullRequestURL for GitLab correctly follows GitLab's merge request URL structure, enabling direct access to merge request pages.

54-59: The implementation of extractPullRequestID for GitLab is well-suited for parsing GitLab's specific merge request commit messages.

Consider adding a comment detailing the expected format of the commit message this function is designed to parse. This can help future maintainers understand the specific context and limitations of this implementation.

pull_request_url.ts (1)

59-70: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [45-83]

The integration of the hostingService parameter into getPullRequestContains and the subsequent use of the extractPullRequestID method are well-implemented, aligning with the PR's objectives to enhance pull request handling.

It would be beneficial to add tests covering these changes to ensure the new functionality works as expected across different hosting services. Would you like assistance in creating these tests?

lambdalisue · 2024-03-17T10:07:30Z

@kitagry CI was disabled and there was a lint issue so could you rebase from the current main?

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4b51785 and 3b28b95.

Files selected for processing (4)

hosting_service/mod.ts (1 hunks)
hosting_service/services/github_com.ts (1 hunks)
hosting_service/services/gitlab_com.ts (1 hunks)
pull_request_url.ts (6 hunks)

Files skipped from review as they are similar to previous changes (4)

hosting_service/mod.ts
hosting_service/services/github_com.ts
hosting_service/services/gitlab_com.ts
pull_request_url.ts

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a09fd3e and d643548.

Files selected for processing (4)

hosting_service/mod.ts (1 hunks)
hosting_service/services/github_com.ts (1 hunks)
hosting_service/services/gitlab_com.ts (1 hunks)
pull_request_url.ts (6 hunks)

Files skipped from review as they are similar to previous changes (4)

hosting_service/mod.ts
hosting_service/services/github_com.ts
hosting_service/services/gitlab_com.ts
pull_request_url.ts

kitagry · 2024-03-18T04:31:16Z

Hmm, snapshot test is not correct 🤔

If you don't mind, I will rewrite exact value test instead of snapshot test. Do you think about this?

lambdalisue · 2024-03-18T15:57:41Z

Hmm, snapshot test is not correct 🤔

What do you mean "not correct"? Did you update snapshot?

kitagry · 2024-03-19T01:55:04Z

I'm sorry, I misunderstand 🙏

I'll update snapshot. 🙇

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a09fd3e and 2339c8d.

Files ignored due to path filters (1)

hosting_service/__snapshots__/mod_test.ts.snap is excluded by: !**/*.snap

Files selected for processing (4)

hosting_service/mod.ts (1 hunks)
hosting_service/services/github_com.ts (1 hunks)
hosting_service/services/gitlab_com.ts (1 hunks)
pull_request_url.ts (6 hunks)

Files skipped from review as they are similar to previous changes (4)

hosting_service/mod.ts
hosting_service/services/github_com.ts
hosting_service/services/gitlab_com.ts
pull_request_url.ts

kitagry · 2024-03-29T06:30:48Z

Hi @lambdalisue . Could you review this?

lambdalisue · 2024-03-29T18:14:36Z

Thanks 🎉

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

lambdalisue closed this Mar 17, 2024

lambdalisue reopened this Mar 17, 2024

kitagry force-pushed the gitlab-pull-request-url branch from e5809eb to 3b28b95 Compare March 17, 2024 11:53

coderabbitai bot reviewed Mar 17, 2024

View reviewed changes

kitagry force-pushed the gitlab-pull-request-url branch from 3b28b95 to d643548 Compare March 18, 2024 00:05

coderabbitai bot reviewed Mar 18, 2024

View reviewed changes

✨ Open GitLab merge request page

2339c8d

kitagry force-pushed the gitlab-pull-request-url branch from d643548 to 2339c8d Compare March 19, 2024 01:56

coderabbitai bot reviewed Mar 19, 2024

View reviewed changes

lambdalisue approved these changes Mar 29, 2024

View reviewed changes

lambdalisue merged commit 58181b2 into lambdalisue:main Mar 29, 2024

kitagry deleted the gitlab-pull-request-url branch March 30, 2024 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Open GitLab merge request page #15

✨ Open GitLab merge request page #15

kitagry commented Mar 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

lambdalisue commented Mar 17, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

kitagry commented Mar 18, 2024

lambdalisue commented Mar 18, 2024

kitagry commented Mar 19, 2024

coderabbitai bot left a comment

kitagry commented Mar 29, 2024

lambdalisue commented Mar 29, 2024

✨ Open GitLab merge request page #15

✨ Open GitLab merge request page #15

Conversation

kitagry commented Mar 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 17, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

lambdalisue commented Mar 17, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

kitagry commented Mar 18, 2024

lambdalisue commented Mar 18, 2024

kitagry commented Mar 19, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

kitagry commented Mar 29, 2024

lambdalisue commented Mar 29, 2024

kitagry commented Mar 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 17, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)