Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Avoid using https:// imports #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2024
Merged

🐛 Avoid using https:// imports #18

merged 1 commit into from
Apr 6, 2024

Conversation

lambdalisue
Copy link
Owner

@lambdalisue lambdalisue commented Apr 6, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Updated import paths across various files to use custom aliases and modules for improved maintainability and consistency.
  • Tests
    • Modified test files to reference custom module paths, aligning with the new import strategy.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 6, 2024 •
edited
Loading

Walkthrough

The recent updates involve standardizing import paths across several TypeScript files, shifting from direct URLs to custom aliases that utilize a jsr protocol. This change enhances modularity and simplifies dependency management within the project. Additionally, there's a tweak in how configuration directories are accessed, further aligning with the new import strategy.

Changes

Files Summary
bin/browse.ts Updated import paths to use custom aliases; modified readAliasesFile for configuration access.
process_test.ts, util_test.ts Imports now use "jsr:@std/assert" and "jsr:@std" for Deno standard library modules.
hosting_service/.../mod_test.ts, .../bitbucket_org.ts Updated import paths to use the jsr protocol for Deno standard library modules.

"In the digital meadow, under the silicon sky,
A rabbit hops along, with code that never lies.
🐾 With each leap, a path anew, jsr in its stride,
🌟 Through modules and bits, it finds its guide.
In the realm of code, where changes abide,
This rabbit thrives, with joy it cannot hide."
🚀🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lambdalisue lambdalisue merged commit 6c97c32 into main Apr 6, 2024
2 checks passed
@lambdalisue lambdalisue deleted the fix-jsr branch April 6, 2024 06:57
coderabbitai[bot]
coderabbitai bot reviewed Apr 6, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
process_test.ts (1)

Line range hint 5-12: The test cases are correctly implemented, using appropriate assertions and handling asynchronous operations effectively.

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e23aa3c and a461ef5.
Files selected for processing (5)
  • bin/browse.ts (2 hunks)
  • hosting_service/mod_test.ts (1 hunks)
  • hosting_service/services/bitbucket_org.ts (1 hunks)
  • process_test.ts (1 hunks)
  • util_test.ts (1 hunks)
Additional comments not posted (6)
process_test.ts (1)

1-1: The update to use the custom module protocol "jsr:@std/assert" aligns with the PR's objectives and is correctly implemented.

hosting_service/services/bitbucket_org.ts (1)

3-3: The update to use the custom module protocol "jsr:@std/path" for importing extname is correctly implemented and aligns with the PR's objectives.

bin/browse.ts (2)

2-6: The updates to use custom module protocols for importing modules align with the PR's objectives and are correctly implemented.

56-56: The modification in the readAliasesFile function to use await dir("config") for obtaining the configuration directory is a good practice, enhancing maintainability.

hosting_service/mod_test.ts (1)

1-2: The updates to use custom module paths with the "jsr" protocol for importing modules are correctly implemented and align with the PR's objectives.

util_test.ts (1)

1-2: The updates to use custom module paths prefixed with "jsr:@std" for importing modules are correctly implemented and align with the PR's objectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lambdalisue