-
Notifications
You must be signed in to change notification settings - Fork 509
feat: parse Ref from version and version numbers #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Code ReviewP0 - Ambiguity between tags and branches without "/": The Currently Consider either:
P1 - Inconsistency with existing The existing impl From<&str> for Ref {
fn from(reference: &str) -> Self {
Tag(reference.to_string())
}
}But |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Ref
Ref|
I'd +1 the automated code review concern here: how do we differentiate from branches? We can maybe add some additional rules for what is a valid tag. It seems like this might be worth designing the API in an issue first before going into implementation. There any background on this feature? Why did you decide to implement it? |
This PR allows users to parse a str into
Ref.For example:
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.