Code Review

Summary

This PR migrates Error::Internal from using snafu's location!() macro to capturing full stack traces via std::backtrace::Backtrace::force_capture(). This is a valuable improvement for debugging internal errors.

P0/P1 Issues

P1: Performance concern with force_capture()

In rust/lance-core/src/error.rs:130, the constructor uses Backtrace::force_capture():

pub fn internal(message: impl Into<String>) -> Self {
    let message: String = message.into();
    Self::Internal {
        source: InternalError {
            message,
            backtrace: std::backtrace::Backtrace::force_capture(),
        },
    }
}

force_capture() always captures a backtrace regardless of the RUST_BACKTRACE environment variable setting. This is intentional for debugging internal errors, but has a performance cost. Consider whether Backtrace::capture() (which respects RUST_BACKTRACE) might be more appropriate for production use cases, or document that this is the intended behavior for internal errors since they represent bugs that should be reported.

LGTM overall. The refactoring is mechanical and correct. The test update in page_table.rs correctly adapts to the new error structure by checking .to_string() instead of pattern matching on the message field directly.

Codecov Report

❌ Patch coverage is 21.41058% with 312 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!