Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(rust): support diff insert/update data between versions #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(rust): support diff insert/update data between versions #4741

wants to merge 18 commits into from

Conversation

yanghua
Copy link
Collaborator

@yanghua yanghua commented Sep 16, 2025

No description provided.

@github-actions github-actions bot added enhancement New feature or request python labels Sep 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.37942% with 274 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (20fceb1) to head (4a400d7).

Files with missing lines Patch % Lines
rust/lance/src/dataset/delta.rs 86.99% 94 Missing and 34 partials ⚠️
rust/lance-table/src/rowids/version.rs 74.24% 102 Missing and 9 partials ⚠️
rust/lance/src/dataset.rs 0.00% 15 Missing ⚠️
rust/lance/src/dataset/optimize.rs 77.96% 8 Missing and 5 partials ⚠️
rust/lance/src/dataset/write/merge_insert.rs 84.61% 5 Missing and 1 partial ⚠️
rust/lance-table/src/format/fragment.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
+ Coverage   80.84%   80.88%   +0.03%     
==========================================
  Files         330      331       +1     
  Lines      130545   132097    +1552     
  Branches   130545   132097    +1552     
==========================================
+ Hits       105540   106843    +1303     
- Misses      21269    21468     +199     
- Partials     3736     3786      +50
Flag Coverage Δ
unittests 80.88% <82.37%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the java label Sep 17, 2025
@yanghua yanghua force-pushed the feat-diff-upsert branch 3 times, most recently from c95501d to cdb9678 Compare September 19, 2025 03:47
@yanghua yanghua marked this pull request as ready for review September 19, 2025 15:12
@yanghua yanghua requested a review from jackye1995 September 19, 2025 15:12
@yanghua
Copy link
Collaborator Author

yanghua commented Sep 19, 2025

@jackye1995 When you have time, PTAL! thanks.

jackye1995
jackye1995 reviewed Sep 24, 2025
View reviewed changes
jackye1995
jackye1995 reviewed Sep 26, 2025
View reviewed changes
jackye1995
jackye1995 reviewed Sep 28, 2025
View reviewed changes
@jackye1995
Copy link
Contributor

Saw quite a few new changes, let me know when this is ready to be reviewed again!

@yanghua
Copy link
Collaborator Author

yanghua commented Sep 29, 2025

Saw quite a few new changes, let me know when this is ready to be reviewed again!

@jackye1995 Addressed your comments and added new test cases. Please review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackye1995 jackye1995 jackye1995 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request java python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanghua @codecov-commenter @jackye1995