Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fts match query on column without inverted index #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fts match query on column without inverted index #4859

wants to merge 1 commit into from
+860 −119

Conversation

wojiaodoubao
Copy link
Contributor

Close #4780

@wojiaodoubao wojiaodoubao marked this pull request as draft September 30, 2025 12:51
@github-actions github-actions bot added bug Something isn't working python labels Sep 30, 2025
@wojiaodoubao
Copy link
Contributor Author

I'll rebase this pr after #4752 is merged.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.07947% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.96%. Comparing base (8658d2c) to head (6287c7e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-datafusion/src/exec.rs 39.68% 38 Missing ⚠️
rust/lance-index/src/scalar/inverted/scorer.rs 77.96% 13 Missing ⚠️
rust/lance/src/dataset/scanner.rs 86.41% 4 Missing and 7 partials ⚠️
rust/lance-index/src/scalar/inverted/index.rs 97.48% 3 Missing and 2 partials ⚠️
rust/lance-datafusion/src/datagen.rs 85.71% 1 Missing and 2 partials ⚠️
rust/lance/src/io/exec/fts.rs 91.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4859      +/-   ##
==========================================
+ Coverage   80.90%   80.96%   +0.05%     
==========================================
  Files         332      332              
  Lines      131478   131969     +491     
  Branches   131478   131969     +491     
==========================================
+ Hits       106376   106846     +470     
- Misses      21351    21369      +18     
- Partials     3751     3754       +3
Flag Coverage Δ
unittests 80.96% <88.07%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wojiaodoubao wojiaodoubao force-pushed the fts-flat-match-fix branch 3 times, most recently from 8ac502f to 62f02c0 Compare October 1, 2025 06:39
@wojiaodoubao wojiaodoubao marked this pull request as ready for review October 1, 2025 11:58
@wojiaodoubao
Copy link
Contributor Author

Hi @jackye1995 @BubbleCal , could you help review this pr when you have time, thank very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow querying empty FTS index
2 participants
@wojiaodoubao @codecov-commenter