chore(rust): make lance-testing a dev-dependency - #3661
Closed
saitejabandaru-in wants to merge 1 commit into
Closed
Conversation
wjones127
self-requested a review
July 14, 2026 20:44
wjones127
approved these changes
Jul 14, 2026
saitejabandaru-in
force-pushed
the
fix/lance-testing-dev-dependency
branch
from
July 16, 2026 00:04
8e877bd to
41d7303
Compare
Contributor
|
Thanks for the contribution, @saitejabandaru-in! Unfortunately this one is already taken care of: #3645 was resolved by #3646 (merged July 14), which moved On current Closing as already resolved — but thanks for spotting the issue and taking the time to send a fix. Hope to see more PRs from you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3645.
Description
Currently,
lance-testingis declared as a direct dependency of thelancedbcrate, pulling in testing-specific dependencies into release builds oflancedb.Since
lance-testingis only used within test modules inconnection.rsandquery.rs, it can be moved to[dev-dependencies]to reduce compilation time and dependency footprint for production builds.Changes
lance-testingfrom[dependencies]to[dev-dependencies]inrust/lancedb/Cargo.toml.