feat(langchain-ibm): Added another case for error to be more descriptive#161
Open
Arad Halevy (aradhalevy) wants to merge 4 commits into
Open
feat(langchain-ibm): Added another case for error to be more descriptive#161Arad Halevy (aradhalevy) wants to merge 4 commits into
Arad Halevy (aradhalevy) wants to merge 4 commits into
Conversation
Signed-off-by: Arad Halevy <[email protected]>
Signed-off-by: Arad Halevy <[email protected]>
Signed-off-by: Arad Halevy <[email protected]>
Signed-off-by: Arad Halevy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Description
Related Issue: #160
π‘ Summary of Changes
Split the error of ""The parameters 'model', 'model_id' and 'deployment_id' are "
"mutually exclusive. Please specify exactly one of these "
"parameters when initializing ChatWatsonx."
To 2 cases to be more descriptive, one when there is no parameter passed and a second when there is more than one passed.
β PR Checklist
PR Title Format:
{TYPE}({SCOPE}): {DESCRIPTION}{TYPE}values:feat,fix,docs,style,refactor,perf,test,build,ci,chore,revert,release{SCOPE}values (optional):langchain-ibm,langchain-db2PR Description: The Description section clearly lists what was changed, why, and how it was tested.
Formatting, Linting & Tests
Run the following commands from the root of the modified package(s):
make format make lint make testSee the contribution guidelines for more details.
π§ͺ Testing (optional)
ποΈ Notes (optional)
Thank you again for helping improve LangChain-IBM! π
Your contribution makes the project better for everyone.