chore(worker): Move nodemon to tsx for reloads from packages/shared #8801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksjogo
commented
Aug 28, 2025
| "start": "dotenv -e ../.env -- node dist/index.js", | ||
| "build": "tsc", | ||
| "dev": "dotenv -e ../.env -- nodemon src/index.ts", | ||
| "dev": "dotenv -e ../.env -- tsx watch --clear-screen=false --include '../packages/shared/dist/*' src/index.ts", |
There was a problem hiding this comment.
Clear screen disabled to not remove other packages output when running the composed dev.
ksjogo
commented
Aug 28, 2025
| '@emotion/[email protected]': | ||
| resolution: {integrity: sha512-snKqtPW01tN0ui7yu9rGv69aJXr/a/Ywvl11sUjNtEcRc+ng/mQriFL0wLXMef74iHa/EkftbDzU9F8iFbH+zg==} | ||
|
|
||
| '@esbuild/[email protected]': |
There was a problem hiding this comment.
These changes seem wrong, not sure what pnpm is doing
Will re-run
ksjogo
commented
Aug 28, 2025
| "eslint-config-standard": "^17.1.0", | ||
| "eslint-plugin-prettier": "^5.1.3", | ||
| "kysely-codegen": "^0.16.8", | ||
| "nodemon": "^3.1.7", |
There was a problem hiding this comment.
Wasn't used in shared, so we can remove
turbo.json
Outdated
| "cache": false, | ||
| "persistent": true, | ||
| "dependsOn": [ | ||
| "@langfuse/shared#build" |
There was a problem hiding this comment.
We had this dependency also in the web container and this was hghly resource intensive. I think we can remove this and hit "pnpm run dev" on initial startup in this repo twice to account for the concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the watcher from the worker's
devtask from nodemon to tsx.This allows for automated reloads in the dev environment when packages/shared changes:
Screen.Recording.2025-08-28.at.22.58.03.mov
It would have been possible to configure nodemon to also listen on the dist dir, but nodemon is generally a bit outdated and tsx well supported. Additionally nodemon on mac not only listens on actualy content changes but also saves without changes, which can lead to issues when spinning up
@langfuse/shared#devand@langfuse/worker#devat the some time, due to tsc in shared dev doing a lot of writes. To help this situationshared#buildis now a depdency ofworker#dev, so the content is updated before tsx starts listening.Type of change
Mandatory Tasks
Important
Replaces
nodemonwithtsxforworkerdev script, updates task dependencies inturbo.json, and removesnodemonfrom dependencies.nodemonwithtsxinworker/package.jsonfordevscript to improve reloads whenpackages/sharedchanges.@langfuse/shared#buildas a dependency forworker#devinturbo.jsonto ensure content is updated beforetsxstarts.nodemonfromdevDependenciesinpackages/shared/package.jsonandworker/package.json.tsxtodevDependenciesinworker/package.json.turbo.jsonfordev:workerandworker#devto include@langfuse/sharedtasks.This description was created by
for 80282ed. You can customize this summary. It will automatically update as commits are pushed.