Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Map gen_ai.input/output.messages to input/output #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Map gen_ai.input/output.messages to input/output #8813

merged 1 commit into from
Sep 2, 2025

Conversation

verdie-g
Copy link
Contributor

@verdie-g verdie-g commented Aug 29, 2025 •
edited
Loading

What does this PR do?

Fixes #8840

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if new and existing unit tests pass locally with my changes

Important

Map gen_ai.input.messages and gen_ai.output.messages to input and output in OtelIngestionProcessor.

  • Behavior:
    • Maps gen_ai.input.messages to input and gen_ai.output.messages to output in OtelIngestionProcessor.
    • Handles these mappings in extractInputAndOutput() function.
  • Tests:
    • Adds test cases in otelMapping.servertest.ts to verify mapping of gen_ai.input.messages and gen_ai.output.messages.
  • Misc:
    • Updates documentation to reflect new mappings.

This description was created by Ellipsis for ac2a4b6. You can customize this summary. It will automatically update as commits are pushed.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feat-api labels Aug 29, 2025
Steffen911
Steffen911 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@Steffen911 Steffen911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this patch!

@Steffen911 Steffen911 added this pull request to the merge queue Sep 2, 2025
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer auto-merge This PR is set to be merged labels Sep 2, 2025
Merged via the queue into langfuse:main with commit 14fbeb1 Sep 2, 2025
28 checks passed
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 2, 2025
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 3, 2025
@verdie-g @gongxh13
Map gen_ai.input/output.messages to input/output (langfuse#8813)
050e538
@dosubot dosubot bot mentioned this pull request Sep 9, 2025
Closed
@dosubot dosubot bot mentioned this pull request Sep 22, 2025
Open
@verdie-g verdie-g mentioned this pull request Sep 30, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffen911 Steffen911 Steffen911 approved these changes

Assignees
No one assigned
Labels
feat-api lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OTEL gen_ai.input.messages/gen_ai.output.messages
3 participants
@verdie-g @CLAassistant @Steffen911