Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marcklingen
Copy link
Member

@marcklingen marcklingen commented Sep 2, 2025

What does this PR do?

This PR introduces a new CI check that validates Pull Request titles against conventional commit message standards. This ensures that when PRs are squash-merged into the main branch, the resulting commit messages consistently follow the desired type(scope): description format, which is crucial for automated changelog generation and commit history clarity.

The check uses amannn/action-semantic-pull-request@v5 and enforces:

  • Allowed conventional commit types (e.g., feat, fix, chore).
  • Optional scopes.
  • A lowercase subject line.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project (pnpm run format)
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings (npm run lint)
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Open in Cursor Open in Web

Important

Adds a CI job to validate PR titles against conventional commit standards using amannn/action-semantic-pull-request@v6.

  • CI/CD Pipeline:
    • Adds validate-pr-title job in pipeline.yml to check PR titles against conventional commit standards.
    • Uses amannn/action-semantic-pull-request@v6 to enforce commit types like feat, fix, chore, etc.
    • Allows optional scopes and requires lowercase subject lines.
    • Job runs on ubuntu-latest and requires pre-job to pass.

This description was created by Ellipsis for 7023dca. You can customize this summary. It will automatically update as commits are pushed.

Copy link

cursor bot commented Sep 2, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@marcklingen marcklingen changed the title Check pr title for conventional commit ci: check pr title for conventional commit Sep 2, 2025
@marcklingen marcklingen marked this pull request as ready for review September 2, 2025 09:19
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 2, 2025
@marcklingen marcklingen changed the title ci: check pr title for conventional commit check pr title for conventional commit Sep 2, 2025
@marcklingen marcklingen changed the title check pr title for conventional commit ci: check pr title for conventional commit Sep 2, 2025
@marcklingen marcklingen merged commit 702dd6a into main Sep 2, 2025
6 checks passed
@marcklingen marcklingen deleted the cursor/check-pr-title-for-conventional-commit-981a branch September 2, 2025 12:18
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants