Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: decouple upload file from url signing in storage service #8878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

chore: decouple upload file from url signing in storage service #8878

merged 1 commit into from
Sep 8, 2025

Conversation

hcadioli
Copy link
Contributor

@hcadioli hcadioli commented Sep 3, 2025 •
edited by ellipsis-dev bot
Loading

What does this PR do?

Fixes issue: #8856

Type of change

I'm decoupling the uploadFile method from url signing in StorageService for s3, azure and GCS

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project (pnpm run format)
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings (npm run lint)
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Important

Decouples uploadFile from URL signing in StorageService, introducing uploadWithSignedUrl for S3, Azure, and GCS.

  • Behavior:
    • Decouples uploadFile from URL signing in StorageService for S3, Azure, and GCS.
    • Introduces uploadWithSignedUrl method for handling URL signing separately.
  • Service Implementations:
    • Updates uploadFile to return void in StorageService.ts.
    • Adds uploadWithSignedUrl to AzureBlobStorageService, S3StorageService, and GoogleCloudStorageService.
  • Tests:
    • Updates tests in dataRetentionProcessing.test.ts, projectDeletionProcessing.test.ts, scoreDeletion.test.ts, storageservice.test.ts, and traceDeletion.test.ts to use uploadWithSignedUrl where URL signing is needed.
  • Misc:
    • Updates handleBatchExportJob.ts, handleBlobStorageIntegrationProjectJob.ts, and coreDataS3ExportQueue.ts to use uploadWithSignedUrl for operations requiring signed URLs.

This description was created by Ellipsis for 191ca10. You can customize this summary. It will automatically update as commits are pushed.

@hcadioli hcadioli force-pushed the upload-file-without-signing branch from a2b46b3 to 177b96e Compare September 3, 2025 03:52
@hcadioli hcadioli force-pushed the upload-file-without-signing branch from 177b96e to 191ca10 Compare September 3, 2025 13:39
@hcadioli hcadioli marked this pull request as ready for review September 3, 2025 17:00
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 3, 2025
@hcadioli hcadioli mentioned this pull request Sep 3, 2025
Closed
@Steffen911 Steffen911 self-requested a review September 8, 2025 07:30
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 8, 2025
@Steffen911 Steffen911 added this pull request to the merge queue Sep 8, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 8, 2025
Merged via the queue into langfuse:main with commit 18deee6 Sep 8, 2025
29 checks passed
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffen911 Steffen911 Steffen911 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcadioli @Steffen911