chore(dataset-run-items): clean up deprecated code #8949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Clean up deprecated code related to dataset run items by removing unused queries, updating schemas, and refining query logic.
getRunLevelScoreKeysAndProps
query fromdataset-router.ts
.getDatasetRunsTableInternal
indataset-run-items.ts
to usebaseFilter.query
instead of hardcoded project and dataset IDs.limit
andoffset
parameters to query parameters ingetDatasetRunsTableInternal
.runIds
andfilter
fromdatasetRunsTableSchema
anddatasetRunTableMetricsSchema
inservice.ts
.datasetId
toqueryKey
inDatasetCompareRunsTableInternal
inDatasetCompareRunsTable.tsx
.useMemo
inDatasetCompareRunsTableInternal
to includedatasetId
.This description was created by
for cd5c39a. You can customize this summary. It will automatically update as commits are pushed.