Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marliessophie
Copy link
Member

@marliessophie marliessophie commented Sep 5, 2025

Important

Clean up deprecated code related to dataset run items by removing unused queries, updating schemas, and refining query logic.

  • Behavior:
    • Removed deprecated getRunLevelScoreKeysAndProps query from dataset-router.ts.
    • Updated getDatasetRunsTableInternal in dataset-run-items.ts to use baseFilter.query instead of hardcoded project and dataset IDs.
    • Added limit and offset parameters to query parameters in getDatasetRunsTableInternal.
  • Schemas:
    • Removed optional runIds and filter from datasetRunsTableSchema and datasetRunTableMetricsSchema in service.ts.
  • Components:
    • Added datasetId to queryKey in DatasetCompareRunsTableInternal in DatasetCompareRunsTable.tsx.
    • Updated dependencies for useMemo in DatasetCompareRunsTableInternal to include datasetId.

This description was created by Ellipsis for cd5c39a. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 5, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 5, 2025
@marliessophie marliessophie added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit a28877b Sep 5, 2025
30 checks passed
@marliessophie marliessophie deleted the marlies/lfe-6397 branch September 5, 2025 08:00
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant