Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marliessophie
Copy link
Member

@marliessophie marliessophie commented Sep 5, 2025

Important

This PR introduces isFixedPosition to mark columns as unmovable, updating column definitions and behavior across multiple components.

  • Behavior:
    • Introduces isFixedPosition property in types.ts to mark columns as unmovable.
    • Updates ColumnVisibilityListItem in data-table-column-visibility-filter.tsx to disable reordering and hiding for fixed columns.
    • Prevents reordering of fixed columns in DataTableColumnVisibilityFilter.
  • Column Definitions:
    • Replaces isPinned with isFixedPosition in score-configs.tsx, sessions.tsx, traces.tsx, AnnotationQueueItemsTable.tsx, AnnotationQueuesTable.tsx, DatasetItemsTable.tsx, DatasetRunAggregateColumnHelpers.tsx, DatasetRunsTable.tsx, DatasetsTable.tsx.
  • Misc:
    • Updates TableSelectionManager.tsx to include isFixedPosition in selection column.

This description was created by Ellipsis for c1029fd. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 5, 2025
@dosubot dosubot bot added auto-merge This PR is set to be merged feat-datasets labels Sep 5, 2025
@marliessophie marliessophie changed the title fix(table-column-visibilty): show pinned columns as unmoveable in visibility drawer fix(table-column-visibilty): show fixed position columns as unmoveable in visibility drawer Sep 5, 2025
@marliessophie marliessophie added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 736f476 Sep 5, 2025
31 checks passed
@marliessophie marliessophie deleted the marlies/lfe-6572-column-visibility branch September 5, 2025 13:58
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-datasets size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant