-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(datasets): support filtering on per-run-basis in compare table #9098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added column filtering capabilities to the DatasetCompareRunsTable and DatasetRunAggregateColumnHelpers. - Introduced useColumnFilterState hook for managing filter state with URL persistence. - Updated DatasetRunItemsByRunTable to accept multiple dataset run IDs. - Enhanced PopoverFilterBuilder to support different button variants for filter actions. - Refactored related components to integrate new filtering features.
… for optional IO support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds per-run filtering support in dataset compare table with UI and backend enhancements.
FilteredRunPills
andPopoverFilterBuilder
.datasetItemsWithRunData
andrunItemCompareCount
queries indataset-router.ts
to support filtering.FilteredRunPills
infiltered-run-pills.tsx
for displaying active filters.DatasetCompareRunsTable
inDatasetCompareRunsTable.tsx
to integrate filtering UI.DatasetAggregateTableCell
inDatasetAggregateTableCell.tsx
to handle new data structure.useColumnFilterState
inuseColumnFilterState.ts
for managing filter states with URL persistence.useDatasetRunAggregateColumns
inuseDatasetRunAggregateColumns.ts
to include filter logic.getRunItemsByRunIdOrItemId
andenrichAndMapToDatasetItemId
inservice.ts
to handle enriched data.dataset-router.ts
to handle new filtering logic and data retrieval.This description was created by
for 0684516. You can customize this summary. It will automatically update as commits are pushed.