Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marliessophie
Copy link
Member

@marliessophie marliessophie commented Sep 12, 2025

Important

Adds per-run filtering support in dataset compare table with UI and backend enhancements.

  • Behavior:
    • Adds per-run filtering in dataset compare table using FilteredRunPills and PopoverFilterBuilder.
    • Updates datasetItemsWithRunData and runItemCompareCount queries in dataset-router.ts to support filtering.
  • UI Components:
    • Introduces FilteredRunPills in filtered-run-pills.tsx for displaying active filters.
    • Updates DatasetCompareRunsTable in DatasetCompareRunsTable.tsx to integrate filtering UI.
    • Modifies DatasetAggregateTableCell in DatasetAggregateTableCell.tsx to handle new data structure.
  • Hooks:
    • Adds useColumnFilterState in useColumnFilterState.ts for managing filter states with URL persistence.
    • Updates useDatasetRunAggregateColumns in useDatasetRunAggregateColumns.ts to include filter logic.
  • Backend:
    • Modifies getRunItemsByRunIdOrItemId and enrichAndMapToDatasetItemId in service.ts to handle enriched data.
    • Updates dataset-router.ts to handle new filtering logic and data retrieval.

This description was created by Ellipsis for 0684516. You can customize this summary. It will automatically update as commits are pushed.

- Added column filtering capabilities to the DatasetCompareRunsTable and DatasetRunAggregateColumnHelpers.
- Introduced useColumnFilterState hook for managing filter state with URL persistence.
- Updated DatasetRunItemsByRunTable to accept multiple dataset run IDs.
- Enhanced PopoverFilterBuilder to support different button variants for filter actions.
- Refactored related components to integrate new filtering features.
@marliessophie marliessophie marked this pull request as ready for review September 15, 2025 12:44
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feat-datasets labels Sep 15, 2025
@marliessophie marliessophie added this pull request to the merge queue Sep 23, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 23, 2025
Merged via the queue into main with commit 2e0a548 Sep 23, 2025
29 checks passed
@marliessophie marliessophie deleted the marlies/lfe-6477 branch September 23, 2025 09:11
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-datasets size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants