Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

leoweigand
Copy link
Contributor

@leoweigand leoweigand commented Sep 16, 2025

Important

Enhance data table row click behavior to open traces and observations in new tabs with Command/Ctrl+click, updating onRowClick logic in data-table.tsx, observations.tsx, and traces.tsx.

  • Behavior:
    • onRowClick function signature in data-table.tsx updated to include event parameter for handling modifier keys.
    • Command/Ctrl+click on rows in observations.tsx and traces.tsx opens the respective trace or observation in a new tab.
    • Prevents default peek behavior if Command/Ctrl+click is detected.
  • Implementation:
    • Constructs URLs for new tabs using traceId, observationId, and timestamp.
    • Uses window.open() to open the constructed URL in a new tab.
  • Files Affected:
    • data-table.tsx: Updated onRowClick logic.
    • observations.tsx: Added Command/Ctrl+click handling for observations.
    • traces.tsx: Added Command/Ctrl+click handling for traces.

This description was created by Ellipsis for 27371f7. You can customize this summary. It will automatically update as commits are pushed.

@leoweigand leoweigand self-assigned this Sep 16, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Sep 16, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 16, 2025
@leoweigand leoweigand added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 8d5c445 Sep 16, 2025
30 checks passed
@leoweigand leoweigand deleted the LFE-6085/open-traces-in-new-tab branch September 16, 2025 16:01
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant