fix(tables): cmd+click opens traces and observations in a new tab #9161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance data table row click behavior to open traces and observations in new tabs with Command/Ctrl+click, updating
onRowClick
logic indata-table.tsx
,observations.tsx
, andtraces.tsx
.onRowClick
function signature indata-table.tsx
updated to includeevent
parameter for handling modifier keys.observations.tsx
andtraces.tsx
opens the respective trace or observation in a new tab.traceId
,observationId
, andtimestamp
.window.open()
to open the constructed URL in a new tab.data-table.tsx
: UpdatedonRowClick
logic.observations.tsx
: Added Command/Ctrl+click handling for observations.traces.tsx
: Added Command/Ctrl+click handling for traces.This description was created by
for 27371f7. You can customize this summary. It will automatically update as commits are pushed.