Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marliessophie
Copy link
Member

@marliessophie marliessophie commented Sep 18, 2025

Important

Resolve composed prompts using PromptService in experimentsRouter to ensure correct prompt data is used for validation.

  • Behavior:
    • Use PromptService to resolve prompts in validateConfig query in router.ts.
    • Return error if resolved prompt is not found or has no variables/placeholders.
  • Validation:
    • Update variable extraction to use resolvedPrompt instead of prompt.
    • Ensure dataset items contain variables before proceeding.

This description was created by Ellipsis for f9af2de. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Sep 18, 2025
@marliessophie marliessophie changed the title fix(experiments): resolve composed prompts for prompt-experiment setup fix(experiments-ui): resolve composed prompts for prompt-experiment setup Sep 18, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 18, 2025
@marliessophie marliessophie added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit 4c5828d Sep 18, 2025
31 checks passed
@marliessophie marliessophie deleted the marlies/lfe-6779 branch September 18, 2025 10:02
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant