Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(langchain): deployment version in azure model #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

fix(langchain): deployment version in azure model #1203

merged 4 commits into from
Jun 3, 2025

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jun 3, 2025 •
edited by ellipsis-dev bot
Loading

Important

Fixes AzureOpenAI model name extraction to prevent duplicate version strings and updates version to 2.60.7.

  • Behavior:
    • Fixes AzureOpenAI model name extraction in _extract_model_name() to prevent duplicate version strings in deployment names.
    • Ensures deployment_version is not appended if already present in deployment_name.
  • Misc:
    • Updates version from 2.60.5 to 2.60.7 in version.py and pyproject.toml.

This description was created by Ellipsis for edf42ae. You can customize this summary. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

This PR fixes Anthropic usage parsing in the Langchain integration and improves model name extraction for Azure OpenAI, with version bump to 2.60.7.

  • Fixed AzureOpenAI model name extraction to prevent duplicate version strings in deployment names
  • Improved token usage parsing for various LLM providers to avoid double-counting modality-specific tokens
  • Added validation to ensure token counts don't go below 0 using max(0, value)
  • Enhanced handling of Vertex AI token details across different modalities
  • Updated version from 2.60.5 to 2.60.7 consistently across version.py and pyproject.toml

@hassiebp hassiebp changed the base branch from main to v2-stable June 3, 2025 15:18
greptile-apps[bot]
greptile-apps bot reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp changed the title fix(langchain): anthropic usage parsing (#1194) fix(langchain): deployment version in azure model Jun 3, 2025
hassiebp and others added 3 commits June 3, 2025 17:22
@hassiebp @greptile-apps
Update langfuse/extract_model.py
5af0461 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@hassiebp
push
bd6a065
@hassiebp
push
edf42ae
@hassiebp hassiebp merged commit 80a6066 into v2-stable Jun 3, 2025
4 checks passed
@hassiebp hassiebp deleted the fix-langchain-azure-modelname branch June 3, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hassiebp