Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: resolve GCS bad request error in media uploads. #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2025
+10 −5
Merged

fix: resolve GCS bad request error in media uploads. #1265

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e88f477
fix: Add cloud storage specific upload headers
Jay-flow Jul 21, 2025
0149429
add comment
hassiebp Aug 27, 2025
d7c5658
push
hassiebp Aug 27, 2025
3895def
Merge branch 'main' into fix/gcs-bad-request-error
hassiebp Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions langfuse/_task_manager/media_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,15 +246,20 @@ def _process_upload_media_job(

return

headers = {"Content-Type": data["content_type"]}

# In self-hosted setups with GCP, do not add unsupported headers that fail the upload
is_self_hosted_gcs_bucket = "storage.googleapis.com" in upload_url

if not is_self_hosted_gcs_bucket:
headers["x-ms-blob-type"] = "BlockBlob"
headers["x-amz-checksum-sha256"] = data["content_sha256_hash"]

upload_start_time = time.time()
upload_response = self._request_with_backoff(
requests.put,
upload_url,
headers={
"Content-Type": data["content_type"],
"x-amz-checksum-sha256": data["content_sha256_hash"],
"x-ms-blob-type": "BlockBlob",
},
headers=headers,
data=data["content_bytes"],
)
upload_time_ms = int((time.time() - upload_start_time) * 1000)
Expand Down