fix(client): add warning message if OTEL_SDK_DISABLED #1291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a warning log in
Langfuse
class to notify whenOTEL_SDK_DISABLED
is set, disabling tracing.__init__()
ofLangfuse
class inclient.py
ifOTEL_SDK_DISABLED
environment variable is set to true, indicating that Langfuse tracing will be disabled.This description was created by
for 89501a5. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Summary
This PR adds a helpful warning message to the Langfuse client initialization process. The change detects when the
OTEL_SDK_DISABLED
environment variable is set to 'true' and displays a clear warning that Langfuse tracing will be disabled and no traces will appear in the UI.The warning is strategically placed in the client constructor after authentication validation but before the LangfuseResourceManager initialization. This timing ensures that users receive immediate feedback about a configuration that would silently prevent tracing from working. The implementation uses the existing
langfuse_logger
and follows a simple check against the environment variable with appropriate case-insensitive handling.This change addresses a common user experience issue where developers might have
OTEL_SDK_DISABLED=true
set in their environment (perhaps from other OpenTelemetry work) and then wonder why their Langfuse traces aren't appearing. Instead of silent failure, users now get explicit notification about why tracing is disabled, which significantly improves the debugging experience.Confidence score: 5/5