Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add robust MCP file configuration writer #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 28, 2025
Merged

feat: add robust MCP file configuration writer #204

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7ef74d3
feat: add robust MCP file configuration writer
ashleyhindle Aug 27, 2025
a3a7afe
test: fix tests now indentation changed to count of spaces rather tha…
ashleyhindle Aug 27, 2025
f58b3f2
Merge branch 'main' into dont-overwrite-invalid-json
ashleyhindle Aug 27, 2025
283ee39
feat: improve indentation lines
ashleyhindle Aug 27, 2025
9693354
feat: improve json reading error handling
ashleyhindle Aug 27, 2025
ab60b26
style: add newline to fixture
ashleyhindle Aug 27, 2025
e19a452
test: fix test failing on MacOS now we don't do home expansion
ashleyhindle Aug 27, 2025
40183ed
Merge branch 'main' into dont-overwrite-invalid-json
ashleyhindle Aug 27, 2025
16874a9
refactor: improve readability of comma detection
ashleyhindle Aug 27, 2025
70e5e12
add new line to fixtures
pushpak1300 Aug 28, 2025
1839e11
Merge branch 'main' into dont-overwrite-invalid-json
pushpak1300 Aug 28, 2025
dc2146e
feat: add duplicate protection for JSON 5 files
ashleyhindle Aug 28, 2025
1f899a8
refactor: filewriter: less magic numbers
ashleyhindle Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test failing on MacOS now we don't do home expansion
  • Loading branch information
@ashleyhindle
ashleyhindle committed Aug 27, 2025
commit e19a45296edf6ca4cd559452f4e7e6000aef159a
6 changes: 3 additions & 3 deletions tests/Unit/Install/HerdTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,17 @@ function getHerdTestTempDir(): string
expect($herd->mcpPath())->toBe($expected);
})->onlyOnWindows();

test('isMcpAvailable returns false when MCP file is missing', function () {
test('isMcpAvailable returns false when MCP file is missing from home', function () {
$testHome = getHerdTestTempDir().'/home';
mkdir($testHome, 0755, true);
$_SERVER['HOME'] = $testHome;

$herd = new Herd;

expect($herd->isMcpAvailable())->toBeFalse();
});
})->onlyOnWindows();

test('isMcpAvailable returns true when MCP file exists', function () {
test('isMcpAvailable returns true when MCP file exists in home', function () {
$testHome = getHerdTestTempDir().'/home';
mkdir($testHome, 0755, true);
$_SERVER['HOME'] = $testHome;
Expand Down