[5.2] expose token methods to user in password broker#13054
Merged
Conversation
Member
|
Can all this be done by calling ->getRepository() and then calling whatever methods you want? You're just wanting these methods for convenience? |
Contributor
Author
|
i guess technically yes. this makes the code feel a little more descriptive and easy to follow to me, and hopefully others as well. thanks. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR references internals issue 12. please read my initial comment on that page for my reason behind submitting this PR.
by giving the user access to the token repository, they now have full control over resetting passwords. the user is given free reign over validating the input, sending emails, and other things they would like to do.
here is how i would use it in a controller or service class.