[5.2] Fix seeAuthenticatedAs#13308
Merged
Merged
Conversation
Contributor
|
This would not properly support the (probably small) case in which the user objects being compared are of different types. It could result in false positives if the objects have equa authentication identifiers (which is, by default, the primary key of the model). Perhaps you should assert that the types are the same too? |
…ent the same user
b530361 to
921a4d9
Compare
Contributor
Author
|
I think this should be fine now, what do you think @thecrypticace? And thank you for pointing out that possible scenario. |
Contributor
|
Yeah, that looks good to me. |
Contributor
Author
|
@GrahamCampbell or @taylorotwell can you please review and merge this today? (if everything is OK) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug when seeAuthenticatedAs is called with a different user object than the user returned by Auth::user() even when they both represent the same user. I attempt to solve this problem comparing through
getAuthIdentifier()instead of the objects directly.