Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[5.2] Improvements for SessionGuard methods loginUsingId and onceUsingId#13393

Merged
taylorotwell merged 6 commits into
laravel:5.2from
vlakoff:auth-guard-2
May 2, 2016
Merged

[5.2] Improvements for SessionGuard methods loginUsingId and onceUsingId#13393
taylorotwell merged 6 commits into
laravel:5.2from
vlakoff:auth-guard-2

Conversation

@vlakoff
Copy link
Copy Markdown
Contributor

@vlakoff vlakoff commented May 1, 2016

Follow-up to #12999.

  • Remove redundant session set, as I explained in this message.
  • If loginUsingId didn't find user, don't try to login and return false, instead of producing a load of errors. Note how well it is consistent with onceUsingId.
  • Improve test coverage.

@vlakoff vlakoff mentioned this pull request May 1, 2016
Closed
@taylorotwell taylorotwell merged commit 83a4b3f into laravel:5.2 May 2, 2016
@taylorotwell
Copy link
Copy Markdown
Member

taylorotwell commented May 2, 2016

Thanks.

@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented May 2, 2016

For consistency, maybe both loginUsingId and onceUsingId should return user instance in 5.3?

@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented May 3, 2016

Refs #8836 which fixed onceUsingId for missing user case, but not loginUsingId.

@vlakoff vlakoff deleted the auth-guard-2 branch May 6, 2016 04:41
@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented Aug 3, 2016

Refs #13434 which has unified loginUsingId and onceUsingId return values in 5.3, per my above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlakoff @taylorotwell