[5.2] Validate Uploaded Image Dimensions#13428
Merged
Merged
Conversation
|
|
||
| if (isset($parameters['ratio'])) { | ||
| list($numerator, $denominator) = array_pad(sscanf($parameters['ratio'], '%d/%d'), 2, 1); | ||
|
|
Collaborator
There was a problem hiding this comment.
yeh, there's no way you need an eval in there
Member
Author
There was a problem hiding this comment.
Yes, I was using it for a different implementation but forgot to change. Will fix.
Sent from my iPhone
On May 4, 2016, at 9:09 PM, Graham Campbell [email protected] wrote:
In src/Illuminate/Validation/Validator.php:
if (isset($parameters['width']) && $parameters['width'] != $width ||isset($parameters['min_width']) && $parameters['min_width'] > $width ||isset($parameters['max_width']) && $parameters['max_width'] < $width ||isset($parameters['height']) && $parameters['height'] != $height ||isset($parameters['min_height']) && $parameters['min_height'] > $height ||isset($parameters['max_height']) && $parameters['max_height'] < $height) {return false;}
if (isset($parameters['ratio'])) {list($numerator, $denominator) = array_pad(sscanf($parameters['ratio'], '%d/%d'), 2, 1);
return eval("return {$numerator}/{$denominator};") == $width / $height;—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
Member
|
Guess we'll also need a new language line and docs entry for this. |
Member
Author
|
Will take care of that in a couple of hours :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new validation rule:
Available rules are:
min_widthmin_heightmax_widthmax_heightwidthheightratio