[5.1] Account for __isset changes in PHP 7#13509
Merged
Merged
Conversation
Update: this is a revised PR after speaking with Taylor about the intended behavior and possible solutions. PHP 7 has fixed a bug with __isset which affects both the native isset and empty methods. This causes specific issues with checking isset or empty on relations in Eloquent. In PHP 7 checking if a property exists on an unloaded relation, for example isset($this->relation->id) is always returning false because unlike PHP 5.6, PHP 7 is now checking the offset of each attribute before chaining to the next one. In PHP 5.6 it would eager load the relation without checking the offset. This change brings back the intended behavior of the core Eloquent model __isset method for PHP 7 so it works like it did in PHP 5.6. For reference, please check the following link, specifically Nikita Popov's comment (core PHP dev) - https://bugs.php.net/bug.php?id=69659
Contributor
|
@tmiskin I ran into the same issue while using Laravel on PHP 7. Great work on this one. Hopefully this gets merged into the framework. |
Member
|
Can y'all test my tweak of this? 09ea8e2 |
Contributor
Author
|
@taylorotwell that works for me |
Contributor
Author
|
@taylorotwell can we get this merged in to 5.2 as well? |
Member
|
I already merged it forward. |
Contributor
Author
|
Thanks, in my testing this was the only major issue I had migrating to 7. |
|
@taylorotwell Any possibility to cherry-pick this for 4.2? Running into this issue trying to use a prod 4.2 app with PHP7. |
Contributor
Author
|
@tmiskin Thank you for the follow-up! Good to hear. Was mainly curious if there was any intention to backporting to 4.2 or if I would need to consider our own solution. |
Contributor
Author
|
@GenPage I would open a pull request with that latest commit from 5.3 into 4.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: this is a revised PR after speaking with Taylor about the intended behavior and possible solutions.
PHP 7 has fixed a bug with __isset which affects both the native isset and empty methods. This causes specific issues with checking isset or empty on relations in Eloquent. In PHP 7 checking if a property exists on an unloaded relation, for example
isset($this->relation->id)is always returning false because unlike PHP 5.6, PHP 7 is now checking the offset of each attribute before chaining to the next one. In PHP 5.6 it would eager load the relation without checking the offset. This change brings back the intended behavior of the core Eloquent model __isset method for PHP 7 so it works like it did in PHP 5.6.For reference, please check the following link, specifically Nikita Popov's comment (core PHP dev) - https://bugs.php.net/bug.php?id=69659