[5.2] Added support for different log levels.#13513
Merged
Merged
Conversation
Collaborator
|
I don't think this needs to go in the core. 👎 from me. I also would suggest a better way of doing it: https://github.com/AltThree/Logger. |
Author
|
OK so you suggest that I use different logging package if I have to use different log levels beside debug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for different logging levels that seems to be implemented but it was missing from this file. Now we can use different logging levels. If we switch from development to production we have different amount of logging information.
This is feature of Monolog and it was added in src/Illuminate/Log/Writer.php but not in src/Illuminate/Foundation/Bootstrap/ConfigureLogging.php
This functionality is not tested since it is part of Monolog.