[5.2] Fix SparkPost doesn't send attachments#13577
Merged
Merged
Conversation
Contributor
Author
|
@treserres Can you post your code? Mail::send('mail', [], function($mail) {
$mail->to('[email protected]')->subject('Sparkpost test');
}); |
|
Sure, here is: Route::get('/tm', function () {
$message = 'Muy buenos días';
$data = [
'from_name' => 'rrr',
'to_name' => 'rrr',
'body' => $message,
];
Mail::send([
"emails.you-have-new-notification",
"emails.you-have-new-notification-plain",
],
$data,
function ($message) {
$message
->to('[email protected]', 'Ricardo')
->subject('Ricardo le ha enviado mensaje');
}
);
}); |
|
I have the same issue reported by @treserres |
Contributor
Author
Call to undefined method Swift_MimePart::getFileName() @treserres This error because the message plain version is in getChildren() array. Soon a fix. |
|
I have the same issue reported by @treserres. |
Member
|
Does anyone have a fix? On Sat, May 28, 2016 at 6:00 AM -0700, "kezkankrayon" [email protected] wrote: I have the same issue reported by @treserres. — |
Contributor
Author
|
@taylorotwell Yes but I'm testing the fix in different cases: billmn@fea984d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix issue #13546.
Here SparkPost's docs on attachments:
https://github.com/SparkPost/sparkpost-api-documentation/blob/master/services/transmissions_api.md#attachment-attributes