[5.2] Builder: Remove code duplication, Add code comments#13746
Closed
vlakoff wants to merge 2 commits into
Closed
[5.2] Builder: Remove code duplication, Add code comments#13746vlakoff wants to merge 2 commits into
vlakoff wants to merge 2 commits into
Conversation
Contributor
Author
|
Mmm, got it. Eloquent builder has to call its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunk(). Added in 11d3e98. Spotted by n7olkachev in [5.2] Add when method to EloquentBuilder #13726 (comment). I can't think of any purpose for this duplication.when()callback (sorry no "-3" comments, I don't get how you manage to write them). See [5.2] Optional query builder calls via a when() method #12878 for the query builder, then [5.2] Add when method to EloquentBuilder #13726 for the eloquent builder. There is also the late [5.2] Make $query->when() return instance if callback return null #13091 😢