[5.2] Update Str::plural() to use intval()#14502
Merged
Merged
Conversation
A lot of the time when you use str_plural() you get the $count value from a form request which returns the number as a string and therefore this plural won't work as expected. This small change should make sure the $count is in integer format. Thanks to @barryvdh for suggesting to do this change deeper in the code.
Collaborator
|
Thank you, but could you please update this to use the |
Using `(int) $count` instead of `intval($count)` as requested.
Contributor
Author
|
@GrahamCampbell Thank you for your suggestion, I have made the requested changes. |
Contributor
|
@GrahamCampbell Could you please explain why |
Contributor
Author
|
@a-komarev from what I understood, if you're using a base of 10, it's a lot faster and therefore preferred. |
tillkruss
pushed a commit
to tillkruss/framework
that referenced
this pull request
Aug 30, 2016
* Update Str::plural() to use intval() A lot of the time when you use str_plural() you get the $count value from a form request which returns the number as a string and therefore this plural won't work as expected. This small change should make sure the $count is in integer format. Thanks to @barryvdh for suggesting to do this change deeper in the code. * Changed to type casting Using `(int) $count` instead of `intval($count)` as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the time when you use str_plural() you get the $count value from a form request which returns the number as a string and therefore this won't work as expected. This small change should make sure the $count is in integer format.
Many thanks to @barryvdh for suggesting to do this change deeper in the code.