Added ability to reference fields in before and after validators#1824
Merged
Conversation
Contributor
|
Yeah this would be good. I use my own custom little wrappers to do this but I can see it of being of use a fair bit. |
Contributor
There was a problem hiding this comment.
Why not just:
$other = isset( $this->data[$parameters[0]] ) ? $this->getValue( [$parameters[0] ) : $parameters[0];
return strtotime($value) < strtotime($other);
Contributor
Author
There was a problem hiding this comment.
An explicit if-else is more readable and conveys the purpose in a clearer manner.
taylorotwell
added a commit
that referenced
this pull request
Jul 9, 2013
Added ability to reference fields in before and after validators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows before and after validators to refer to other fields such as: